Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update wpt test for webmessaging/broadcastchannel #55205

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Nahee-Park
Copy link
Contributor

Updating the web platform tests for the webmessaging/broadcastchannel.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.39%. Comparing base (103b843) to head (4141602).
Report is 169 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55205      +/-   ##
==========================================
+ Coverage   88.23%   88.39%   +0.16%     
==========================================
  Files         651      652       +1     
  Lines      183863   186565    +2702     
  Branches    35824    36042     +218     
==========================================
+ Hits       162235   164923    +2688     
+ Misses      14932    14911      -21     
- Partials     6696     6731      +35     

see 74 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2024
@nodejs-github-bot
Copy link
Collaborator

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 11, 2024
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit eb63cd2 into nodejs:main Oct 22, 2024
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in eb63cd2

aduh95 pushed a commit that referenced this pull request Oct 23, 2024
PR-URL: #55205
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 24, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#55205
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants