src: fix winapi_strerror error string #55207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
targos
reviewed
Oct 1, 2024
test/parallel/test-print-GH-23191.js
Outdated
| @@ -0,0 +1,43 @@ | |||
| // Copyright Joyent, Inc. and other Node contributors. | |||
There was a problem hiding this comment.
We don't add the copyright header in new tests.
There was a problem hiding this comment.
Thanks. Fixed it.
huseyinacacak-janea
force-pushed
the
huseyin-6791-truncated-error-messages
branch
from
95c8b00
to
565a983
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55207 +/- ##
==========================================
+ Coverage 88.07% 88.41% +0.34%
==========================================
Files 652 652
Lines 183546 186838 +3292
Branches 35859 36060 +201
==========================================
+ Hits 161649 165198 +3549
+ Misses 15147 14891 -256
+ Partials 6750 6749 -1
|
RedYetiDev
reviewed
Oct 1, 2024
test/parallel/test-print-GH-23191.js
Outdated
Comment on lines
20
to
22
| if (common.isWindows) { | ||
| testDebugPrint().then(common.mustCall()); | ||
| } |
There was a problem hiding this comment.
Using common.skip is preferred
There was a problem hiding this comment.
Thank you. Fixed it.
huseyinacacak-janea
force-pushed
the
huseyin-6791-truncated-error-messages
branch
from
565a983
to
d8c6d70
Compare
StefanStojanovic
added
the
request-ci
github-actions
bot
removed
the
request-ci
lpinca
added
request-ci
|
Can you use a more descriptive name for the test file? We renamed many test-xxx-gh-xxx.js in the past. |
lpinca
approved these changes
Oct 11, 2024
lpinca
reviewed
Oct 11, 2024
test/parallel/test-print-GH-23191.js
Outdated
|
|
||
| const cp = child.spawn('pwd'); | ||
|
|
||
| cp.on('exit', common.mustCall(function(code) { |
There was a problem hiding this comment.
Suggested change
| cp.on('exit', common.mustCall(function(code) { | |
| cp.on('exit', common.mustCall(function() { |
Or add an assertion for it.
There was a problem hiding this comment.
Thank you. Fixed it.
huseyinacacak-janea
force-pushed
the
huseyin-6791-truncated-error-messages
branch
from
d8c6d70
to
b1f1213
Compare
lpinca
approved these changes
Oct 14, 2024
github-actions
bot
removed
the
request-ci
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 51d8146 |
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Fixes: nodejs#23191 PR-URL: nodejs#55207 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug in printing the error messages when an exception is thrown on Windows.
Fixes: #23191