Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: include .nycrc in coverage workflows #55210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: include .nycrc in coverage workflows #55210

wants to merge 1 commit into from
+6 −0

Conversation

iwuliz
Copy link
Contributor

@iwuliz iwuliz commented Oct 1, 2024

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 1, 2024
@RedYetiDev RedYetiDev added the coverage Issues and PRs related to native coverage support. label Oct 1, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.39%. Comparing base (89a2f56) to head (e7fcaa2).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55210   +/-   ##
=======================================
  Coverage   88.39%   88.39%           
=======================================
  Files         652      652           
  Lines      186565   186565           
  Branches    36046    36045    -1     
=======================================
+ Hits       164916   164919    +3     
- Misses      14908    14913    +5     
+ Partials     6741     6733    -8

see 31 files with indirect coverage changes

@jakecastelli jakecastelli added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 1, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. coverage Issues and PRs related to native coverage support. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@iwuliz @nodejs-github-bot @targos @richardlau @jakecastelli @aduh95 @RedYetiDev