doc: tweak onboarding instructions #55212
Open
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some additional guidance based on something we missed in a recent onboarding step. Signed-off-by: Michael Dawson <midawson@redhat.com>
|
Review requested:
|
|
@abmusse FYI. |
|
Perhaps add a link to https://git-scm.com/docs/gitmailmap as it seems more than one person was not aware that |
Signed-off-by: Michael Dawson <midawson@redhat.com>
|
@richardlau added |
richardlau
approved these changes
Oct 1, 2024
aduh95
approved these changes
Oct 1, 2024
RedYetiDev
reviewed
Oct 1, 2024
| @@ -216,6 +216,13 @@ needs to be pointed out separately during the onboarding. | |||
| `git show --format=%B 6669b3857f0f43ee0296eb7ac45086cd907b9e94` | |||
| * Collaborators are in alphabetical order by GitHub username. | |||
| * Optionally, include your personal pronouns. | |||
| * The PR should include an addition to the | |||
| [mailmap](https://github.com/nodejs/node/blob/main/.mailmap) file if the email | |||
There was a problem hiding this comment.
Suggested change
| [mailmap](https://github.com/nodejs/node/blob/main/.mailmap) file if the email | |
| [mailmap](.mailmap) file if the email |
RedYetiDev
added
the
meta
RafaelGSS
approved these changes
Oct 1, 2024
RedYetiDev
added
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some additional guidance based on something we missed in a recent onboarding step.