Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: tweak onboarding instructions #55212

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −0
Open

doc: tweak onboarding instructions #55212

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d80f2e
doc: tweak onboarding instructions
mhdawson Oct 1, 2024
ce31193
squash: address comments
mhdawson Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions onboarding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,13 @@ needs to be pointed out separately during the onboarding.
`git show --format=%B 6669b3857f0f43ee0296eb7ac45086cd907b9e94`
* Collaborators are in alphabetical order by GitHub username.
* Optionally, include your personal pronouns.
* The PR should include an addition to the
[mailmap](https://github.com/nodejs/node/blob/main/.mailmap) file if the email
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[mailmap](https://github.com/nodejs/node/blob/main/.mailmap) file if the email
[mailmap](.mailmap) file if the email

being added to the collaborator list does not match the email used for
commits. Otherwise tooling will not see the collaborator as being active and
may suggest removing them. See
[gitmailmap](https://git-scm.com/docs/gitmailmap) for information on the
format of the mailmap file.
* Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message
so that when the commit lands, the nomination issue url will be
automatically closed.
Expand Down
Loading