events: extract event listener validation as a function #55230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was some repetitive logics that validated the existence of eventlisteners. We now replace this with a single line of, `hasEventListener(self, type)`. `self` is the object(e.g. EventEmitter) to be checked whether eventlisteners exists or not. `type` is the type of eventlisteners, which can be `undefined`
nodejs-github-bot
added
events
sungpaks
force-pushed
the
has-event-listener-validate-function
branch
from
8f5fd02
to
d7a42a4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55230 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 652 652
Lines 186565 186565
Branches 36038 36042 +4
=======================================
Hits 164935 164935
+ Misses 14914 14900 -14
- Partials 6716 6730 +14
|
github-actions
bot
removed
the
request-ci
jazelly
added
the
author ready
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7a461ed |
aduh95
pushed a commit
that referenced
this pull request
Nov 16, 2024
There was some repetitive logics that validated the existence of eventlisteners. We now replace this with a single line of, `hasEventListener(self, type)`. `self` is the object(e.g. EventEmitter) to be checked whether eventlisteners exists or not. `type` is the type of eventlisteners, which can be `undefined` PR-URL: #55230 Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some repetitive logics that validated the existence of eventlisteners.
We now replace this with a single line of,
hasEventListener(self, type).selfis the object(e.g. EventEmitter) to be checked whether eventlisteners exists or not.typeis the type of eventlisteners, which can beundefined