worker: expose markAsUncloneable api
#55234
Open
+120
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
jazelly
force-pushed
the
expose-uncloneable-api
branch
2 times, most recently
from
f5c09ee
to
c4fbe5d
Compare
jazelly
commented
Oct 2, 2024
| a [`port.postMessage()`][] call, an error is thrown. This is a no-op if `object` is a | ||
| primitive value. | ||
|
|
||
| Note, this does not take effect on `ArrayBuffer`, or any `Buffer` like objects. |
There was a problem hiding this comment.
My understanding is Buffer like objects are from v8 and they have their own SerializeDelegate to handle the Serialization, so marking node's internal flag on or off will not have control over there.
External modules need a way to decorate their objects so that node can recognize it as a host object for serialization process. Exposing a way for turning off instead of turning on is much safer.
jazelly
force-pushed
the
expose-uncloneable-api
branch
from
c4fbe5d
to
fddddad
Compare
|
cc @legendecas |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55234 +/- ##
==========================================
- Coverage 88.39% 88.38% -0.02%
==========================================
Files 652 652
Lines 186565 186586 +21
Branches 36046 36043 -3
==========================================
- Hits 164916 164911 -5
- Misses 14908 14928 +20
- Partials 6741 6747 +6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External modules need a way to decorate their objects so that node can
recognize it as a host object for serialization process. Exposing a way
for turning off instead of turning on is much safer.
Refs: #55178