Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v20.x backport] lib: remove settled dependant signals when they are GCed #55388

Closed

Conversation

geeksilva97
Copy link
Contributor

PR: #55354

PR-URL: nodejs#55354
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Oct 15, 2024
@RedYetiDev
Copy link
Member

Why? The original PR lands cleanly:

$ git cherry-pick 7a7c2b3d0953fa5a8bb69a5d865fce98e0c60669
Auto-merging lib/internal/abort_controller.js
[detached HEAD 7a3ea74466] lib: remove settled dependant signals when they are GCed
 Author: Edigleysson Silva (Edy) <edigleyssonsilva@gmail.com>
 Date: Mon Oct 14 17:33:41 2024 -0300
 2 files changed, 145 insertions(+), 9 deletions(-)
 create mode 100644 test/parallel/test-abortsignal-drop-settled-signals.mjs

@geeksilva97
Copy link
Contributor Author

Why? The original PR lands cleanly:

$ git cherry-pick 7a7c2b3d0953fa5a8bb69a5d865fce98e0c60669
Auto-merging lib/internal/abort_controller.js
[detached HEAD 7a3ea74466] lib: remove settled dependant signals when they are GCed
 Author: Edigleysson Silva (Edy) <edigleyssonsilva@gmail.com>
 Date: Mon Oct 14 17:33:41 2024 -0300
 2 files changed, 145 insertions(+), 9 deletions(-)
 create mode 100644 test/parallel/test-abortsignal-drop-settled-signals.mjs

Hm, so it goes to lower versions? I didn't know that. Thanks for letting me know @RedYetiDev ! will close both.

@RedYetiDev
Copy link
Member

For future reference, a backport is only needed if, when trying to prepare a release, a releaser can't cleanly apply a change. Most changes can be cleanly applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants