sqlite: refactor open options #55442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move options that are only relevant for opening the database into a self-contained class.
nodejs-github-bot
added
c++
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55442 +/- ##
==========================================
- Coverage 88.42% 88.40% -0.02%
==========================================
Files 652 653 +1
Lines 186918 187605 +687
Branches 36079 36120 +41
==========================================
+ Hits 165279 165851 +572
- Misses 14892 14979 +87
- Partials 6747 6775 +28
|
benjamingr
approved these changes
Oct 18, 2024
github-actions
bot
removed
the
request-ci
tniessen
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55442 ✔ Done loading data for nodejs/node/pull/55442 ----------------------------------- PR info ------------------------------------ Title sqlite: refactor open options (#55442) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:sqlite-refactor-open-options -> nodejs:main Labels c++, needs-ci, sqlite Commits 1 - sqlite: refactor open options Committers 1 - Tobias Nießen <tniessen@tnie.de> PR-URL: https://github.com/nodejs/node/pull/55442 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55442 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 18 Oct 2024 09:54:50 GMT ✔ Approvals: 1 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/55442#pullrequestreview-2377857073 ✘ This PR needs to wait 10 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-10-24T17:37:49Z: https://ci.nodejs.org/job/node-test-pull-request/63277/ - Querying data for job/node-test-pull-request/63277/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11509076184 |
tniessen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0668e64 |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2024
Move options that are only relevant for opening the database into a self-contained class. PR-URL: #55442 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Move options that are only relevant for opening the database into a self-contained class. PR-URL: nodejs#55442 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move options that are only relevant for opening the database into a self-contained class.
Refs: #54777 (comment)