Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: define version 10 #55676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

node-api: define version 10 #55676

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented Nov 1, 2024 •
edited
Loading

Notable runtime changes to existing APIs:

  • returning node_api_cannot_run_js instead of napi_pending_exception.
  • allow creating references to objects, functions, and symbols.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/node-api
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 1, 2024
@gabrielschulhof gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Nov 1, 2024
@gabrielschulhof
Copy link
Contributor Author

To discuss: --force-node-api-uncaught-exceptions-policy

@gabrielschulhof gabrielschulhof marked this pull request as ready for review November 15, 2024 03:44
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (b02cd41) to head (66d9b4e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/node_api.cc 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55676      +/-   ##
==========================================
- Coverage   88.42%   88.41%   -0.01%     
==========================================
  Files         654      654              
  Lines      187852   187854       +2     
  Branches    36134    36140       +6     
==========================================
- Hits       166102   166098       -4     
- Misses      14989    14999      +10     
+ Partials     6761     6757       -4
Files with missing lines Coverage Δ
src/js_native_api_v8.cc 76.51% <100.00%> (ø)
src/js_native_api_v8.h 90.90% <ø> (ø)
src/node_api.cc 76.07% <0.00%> (-0.19%) ⬇️

... and 35 files with indirect coverage changes

@gabrielschulhof gabrielschulhof force-pushed the node-api-10-proposal branch 2 times, most recently from 41249af to c8e1c65 Compare November 15, 2024 14:53
@gabrielschulhof
node-api: define version 10
66d9b4e 
Notable runtime changes to existing APIs:
- returning `node_api_cannot_run_js` instead of
  `napi_pending_exception`.
- allow creating references to objects, functions, and symbols.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API.
Projects
Node-API Team Project
Status: Has PR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielschulhof @nodejs-github-bot