Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-11-11, Version 23.2.0 (Current) #55741

Merged
merged 93 commits into from
Nov 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
93 commits
Select commit Hold shift + click to select a range
0ea74f3
test,crypto: make crypto tests work with BoringSSL
codebytere Oct 24, 2024
69dd1e1
module: add module.stripTypeScriptTypes
marco-ippolito Oct 24, 2024
9dcca54
doc: add jazelly to collaborators
jazelly Oct 25, 2024
2d19614
test: increase test coverage for `http.OutgoingMessage.appendHeader()`
juanarbol Oct 25, 2024
adda37f
module: add `findPackageJSON` util
JakobJingleheimer Oct 25, 2024
88c7f5b
sqlite: refactor open options
tniessen Oct 26, 2024
53a7d8e
test,crypto: update WebCryptoAPI WPT
panva Oct 26, 2024
1b82013
deps: update undici to 6.20.1
nodejs-github-bot Oct 26, 2024
71cc20a
test: avoid `apply()` calls with large amount of elements
LiviaMedeiros Oct 26, 2024
f00ad27
doc: add esm examples to node:string_decoder
mfdebian Oct 26, 2024
649d767
test: increase coverage of `pathToFileURL`
aduh95 Oct 27, 2024
bb78904
build: fix GN build for sqlite and nghttp2
codebytere Oct 27, 2024
f77bf65
doc: add suggested tsconfig for type stripping
marco-ippolito Oct 27, 2024
fa61dce
doc: move typescript support to active development
marco-ippolito Oct 27, 2024
f628fc4
fs: make `dirent.path` writable
aduh95 Oct 28, 2024
f8df27a
build: fix GN arg used in generate_config_gypi.py
codebytere Oct 28, 2024
a9e08cf
module: allow ESM that failed to be required to be re-imported
joyeecheung Oct 28, 2024
f92f20b
http: don't emit error after destroy
ronag Oct 28, 2024
efa142c
src: migrate `String::Value` to `String::ValueView`
RedYetiDev Oct 29, 2024
50552fd
deps: update acorn to 8.13.0
nodejs-github-bot Oct 29, 2024
3a1d490
deps: update nghttp2 to 1.64.0
nodejs-github-bot Oct 29, 2024
016baae
src: do not run IsWindowsBatchFile on non-windows
anonrig Oct 29, 2024
b3971bb
module: trim off internal stack frames for require(esm) warnings
joyeecheung Oct 18, 2024
d3be3da
module: fix error thrown from require(esm) hitting TLA repeatedly
joyeecheung Oct 29, 2024
6aa797d
test: remove unneeded listeners
lpinca Oct 29, 2024
4887214
build: fix building with system icu 76
cho-m Oct 29, 2024
815e252
test: split up test-runner-mock-timers test
badkeyy Oct 30, 2024
f355054
doc: capitalize "MIT License"
RedYetiDev Oct 30, 2024
0906004
dns: stop using deprecated `ares_query`
RedYetiDev Oct 30, 2024
4676184
src: use NewFromUtf8Literal in NODE_DEFINE_CONSTANT
ckerr Oct 31, 2024
2ec4ae7
sqlite: add readOnly option
tniessen Oct 31, 2024
25b1422
http: add diagnostic channel `http.client.request.created`
marco-ippolito Oct 31, 2024
56c46ab
module: unify TypeScript and .mjs handling in CommonJS
joyeecheung Oct 31, 2024
137aa5c
http2: fix client async storage persistence
orgads Oct 31, 2024
2b99285
url: refactor `pathToFileURL` to native
aduh95 Oct 31, 2024
4c34891
src: fix dns crash when failed to create NodeAresTask
theanarkh Nov 1, 2024
5de2567
doc: improve c++ embedder API doc
gireeshpunathil Nov 1, 2024
3477492
deps: update amaro to 0.2.0
nodejs-github-bot Nov 1, 2024
3234dc6
test_runner: pass `options` directly to `TestCoverage`
RedYetiDev Nov 1, 2024
cfa4d96
src,lib: optimize nodeTiming.uvMetricsInfo
RafaelGSS Oct 30, 2024
34483a2
benchmark: add nodeTiming.uvmetricsinfo bench
RafaelGSS Oct 31, 2024
b1ca7ab
meta: show PR/issue title on review-wanted
RedYetiDev Nov 1, 2024
7ab1f46
build: stop pre-compiling `lint-md`
RedYetiDev Nov 1, 2024
b79e483
build: use rclone instead of aws CLI
targos Nov 2, 2024
d26dedf
src: refactor ECDHBitsJob signature
panva Nov 2, 2024
9743fa4
doc: remove mention of ECDH-ES in crypto.diffieHellman
panva Nov 2, 2024
6662752
doc: add a note on console stream behavior
gireeshpunathil Nov 2, 2024
8d0526f
http: add diagnostic channel `http.server.response.created`
marco-ippolito Nov 2, 2024
7ce7eab
tools: lint README lists more strictly
aduh95 Nov 2, 2024
0302efe
src: move more key related stuff to ncrypto
jasnell Nov 2, 2024
6ab59c8
os: improve path check with direct index access
mertcanaltin Nov 2, 2024
7af76ef
assert: fix the string length check for printing the simple diff
puskin94 Nov 2, 2024
869e88c
module: simplify `findPackageJSON` implementation
aduh95 Nov 2, 2024
d0ea981
meta: make review-wanted message minimal
RedYetiDev Nov 2, 2024
dd9b683
Revert "fs,win: fix bug in paths with trailing slashes"
rvagg Nov 2, 2024
c2fcda4
typings: fix `ModulesBinding` types
aduh95 Nov 2, 2024
b8ca9d8
doc: add write flag when open file as the demo code's intention
robberfree Nov 2, 2024
505ff19
doc: broken `PerformanceObserver` code sample
domharrington Nov 2, 2024
cba05cd
tools: run daily WPT.fyi report on all supported releases
panva Nov 2, 2024
d0b2d6b
tools: compact jq output in daily-wpt-fyi.yml action
panva Nov 2, 2024
dfb764c
deps: update sqlite to 3.47.0
nodejs-github-bot Nov 2, 2024
9b351b0
crypto: fix `RSA_PKCS1_PADDING` error message
richardlau Nov 3, 2024
19b1edf
module: simplify --inspect-brk handling
joyeecheung Nov 3, 2024
d79c8bf
meta: bump github/codeql-action from 3.26.10 to 3.27.0
dependabot[bot] Nov 3, 2024
5c2e472
meta: bump actions/checkout from 4.2.0 to 4.2.2
dependabot[bot] Nov 3, 2024
9042e9a
meta: bump actions/cache from 4.0.2 to 4.1.2
dependabot[bot] Nov 3, 2024
42e6c47
meta: bump actions/upload-artifact from 4.4.0 to 4.4.3
dependabot[bot] Nov 3, 2024
2ae8d3b
meta: bump rtCamp/action-slack-notify from 2.3.0 to 2.3.2
dependabot[bot] Nov 3, 2024
21e3b7b
meta: bump actions/setup-node from 4.0.4 to 4.1.0
dependabot[bot] Nov 3, 2024
7bfd295
meta: bump actions/setup-python from 5.2.0 to 5.3.0
dependabot[bot] Nov 3, 2024
8fc962f
tools: fix root certificate updater
richardlau Nov 1, 2024
535f1b0
crypto: update root certificates to NSS 3.104
richardlau Nov 1, 2024
7aa250a
sqlite: improve error handling using MaybeLocal
tniessen Nov 4, 2024
961cbc9
tools: use `util.parseArgs` in `lint-md`
RedYetiDev Nov 4, 2024
4b192da
deps: update acorn to 8.14.0
nodejs-github-bot Nov 5, 2024
aebf676
test,crypto: update WebCryptoAPI WPT
panva Nov 5, 2024
bf552fa
lib: prefer number to string in webidl `type` function
jazelly Oct 24, 2024
d1965f9
lib: implement webidl dictionary converter and use it in structuredClone
jazelly Oct 20, 2024
bffbaa1
doc: update `--max-semi-space-size` description
joebowbeer Nov 5, 2024
038ac01
path,win: fix bug in resolve and normalize
huseyinacacak-janea Nov 5, 2024
15028dd
tools: update ESLint to 9.14.0
dependabot[bot] Nov 5, 2024
7d93c0c
test: refactor some esm tests
aduh95 Nov 5, 2024
9dbb255
assert: fix `deepStrictEqual` on errors when `cause` is not undefined
geeksilva97 Nov 5, 2024
10b68ed
test: ignore unrelated events in FW watch tests
Ceres6 Nov 6, 2024
7853462
src: provide workaround for container-overflow
lemire Nov 6, 2024
20cb52d
doc: clarity to available addon options
preveen-stack Nov 6, 2024
4129bc7
util: do not catch on circular `@@toStringTag` errors
RedYetiDev Nov 6, 2024
19da4de
test: update `performance-timeline` wpt
RedYetiDev Sep 30, 2024
ee12431
doc: consistent use of word child process
gireeshpunathil Nov 6, 2024
89aa838
doc: add esm example in `path.md`
RedYetiDev Nov 8, 2024
cbe09b5
doc: add path aliases typescript doc
Ceres6 Nov 8, 2024
355af0f
doc: consolidate history table of `CustomEvent`
geeksilva97 Nov 9, 2024
a83fbdb
2024-11-11, Version 23.2.0 (Current)
aduh95 Nov 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
13 changes: 13 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,16 @@ updates:
applies-to: version-updates
patterns:
- '*'

- package-ecosystem: npm
directory: /tools/lint-md
schedule:
interval: monthly
commit-message:
prefix: tools
open-pull-requests-limit: 10
groups:
lint-md:
applies-to: version-updates
patterns:
- '*'
4 changes: 2 additions & 2 deletions .github/workflows/auto-start-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ jobs:
if: needs.get-prs-for-ci.outputs.numbers != ''
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false

- name: Install Node.js
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NODE_VERSION }}

Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build-tarball.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
Expand All @@ -64,19 +64,19 @@ jobs:
mkdir tarballs
mv *.tar.gz tarballs
- name: Upload tarball artifact
uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
with:
name: tarballs
path: tarballs
test-tarball-linux:
needs: build-tarball
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/commit-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
run: |
echo "plusOne=$((${{ github.event.pull_request.commits }} + 1))" >> $GITHUB_OUTPUT
echo "minusOne=$((${{ github.event.pull_request.commits }} - 1))" >> $GITHUB_OUTPUT
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: ${{ steps.nb-of-commits.outputs.plusOne }}
persist-credentials: false
- run: git reset HEAD^2
- name: Install Node.js
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NODE_VERSION }}
- name: Validate commit message
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/commit-queue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
if: needs.get_mergeable_prs.outputs.numbers != ''
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
# Needs the whole git history for ncu to work
# See https://github.com/nodejs/node-core-utils/pull/486
Expand All @@ -71,7 +71,7 @@ jobs:

# Install dependencies
- name: Install Node.js
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NODE_VERSION }}
- name: Install @node-core/utils
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/coverage-linux-without-intl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/coverage-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/coverage-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: windows-2022
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install deps
Expand Down
32 changes: 19 additions & 13 deletions .github/workflows/daily-wpt-fyi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ name: Daily WPT report

on:
workflow_dispatch:
inputs:
node-versions:
description: Node.js versions (as supported by actions/setup-node) to test as JSON array
required: false
default: '["current", "lts/*", "lts/-1"]'
schedule:
# This is 20 minutes after `epochs/daily` branch is triggered to be created
# in WPT repo.
Expand All @@ -24,16 +19,27 @@ permissions:
contents: read

jobs:
report:
collect-versions:
if: github.repository == 'nodejs/node' || github.event_name == 'workflow_dispatch'
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.query.outputs.matrix }}
steps:
- id: query
run: |
matrix=$(curl -s https://raw.githubusercontent.com/nodejs/Release/refs/heads/main/schedule.json | jq -c --arg now "$(date +%Y-%m-%d)" '[with_entries(select(.value.end > $now and .value.start < $now)) | keys[] | ltrimstr("v") | tonumber] + ["latest-nightly"]')
echo "matrix=$matrix" >> "$GITHUB_OUTPUT"
report:
needs:
- collect-versions
strategy:
matrix:
node-version: ${{ fromJSON(github.event.inputs.node-versions || '["latest-nightly", "current", "lts/*", "lts/-1"]') }}
node-version: ${{ fromJSON(needs.collect-versions.outputs.matrix) }}
fail-fast: false
runs-on: ubuntu-latest
steps:
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand All @@ -45,7 +51,7 @@ jobs:
run: echo "NIGHTLY=$(curl -s https://nodejs.org/download/nightly/index.json | jq -r '[.[] | select(.files[] | contains("linux-x64"))][0].version')" >> $GITHUB_ENV
- name: Install Node.js
id: setup-node
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NIGHTLY || matrix.node-version }}
check-latest: true
Expand All @@ -57,7 +63,7 @@ jobs:
SHORT_SHA=$(node -p 'process.version.split(/-nightly\d{8}/)[1]')
echo "NIGHTLY_REF=$(gh api /repos/nodejs/node/commits/$SHORT_SHA --jq '.sha')" >> $GITHUB_ENV
- name: Checkout ${{ steps.setup-node.outputs.node-version }}
uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
ref: ${{ env.NIGHTLY_REF || steps.setup-node.outputs.node-version }}
Expand All @@ -73,7 +79,7 @@ jobs:
run: rm -rf wpt
working-directory: test/fixtures
- name: Checkout epochs/daily WPT
uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
repository: web-platform-tests/wpt
persist-credentials: false
Expand All @@ -98,7 +104,7 @@ jobs:
run: rm -rf deps/undici
- name: Checkout undici
if: ${{ env.WPT_REPORT != '' }}
uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
repository: nodejs/undici
persist-credentials: false
Expand All @@ -121,7 +127,7 @@ jobs:
run: cp wptreport.json wptreport-${{ steps.setup-node.outputs.node-version }}.json
- name: Upload GitHub Actions artifact
if: ${{ env.WPT_REPORT != '' }}
uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
with:
path: out/wpt/wptreport-*.json
name: WPT Report for ${{ steps.setup-node.outputs.node-version }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ jobs:
build-lto:
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/doc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,18 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Build
run: NODE=$(command -v node) make doc-only
- uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
- uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
with:
name: docs
path: out/doc
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/find-inactive-collaborators.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: 0
persist-credentials: false

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NODE_VERSION }}

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/find-inactive-tsc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,21 @@ jobs:

steps:
- name: Checkout the repo
uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: 0
persist-credentials: false

- name: Clone nodejs/TSC repository
uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: 0
path: .tmp
persist-credentials: false
repository: nodejs/TSC

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NODE_VERSION }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/license-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- run: ./tools/license-builder.sh # Run the license builder tool
Expand Down
Loading
Loading