build: use glob for dependencies of out/Makefile #55789
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `out/Makefile` target in `Makefile` has an incomplete list of `.gyp` files for Node.js dependencies in `deps`, but also the ones that are listed are unconditional. If using any of the `--shared-*` configure options, it should be possible to still build Node.js if the corresponding directory under `deps` is removed. Convert the explicit list of dependency `*.gyp` files for the `out/Makefile` target to a glob. This will pick up any toplevel `.gyp` files for dependencies present in `deps`.
nodejs-github-bot
added
build
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55789 +/- ##
==========================================
- Coverage 88.38% 87.91% -0.48%
==========================================
Files 654 654
Lines 187575 187819 +244
Branches 36096 35827 -269
==========================================
- Hits 165795 165119 -676
- Misses 15004 15885 +881
- Partials 6776 6815 +39 |
lpinca
approved these changes
Nov 9, 2024
richardlau
added
request-ci
github-actions
bot
removed
the
request-ci
richardlau
added
the
author ready
anonrig
approved these changes
Nov 9, 2024
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in fe1dd26 |
aduh95
pushed a commit
that referenced
this pull request
Nov 16, 2024
The `out/Makefile` target in `Makefile` has an incomplete list of `.gyp` files for Node.js dependencies in `deps`, but also the ones that are listed are unconditional. If using any of the `--shared-*` configure options, it should be possible to still build Node.js if the corresponding directory under `deps` is removed. Convert the explicit list of dependency `*.gyp` files for the `out/Makefile` target to a glob. This will pick up any toplevel `.gyp` files for dependencies present in `deps`. PR-URL: #55789 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
out/Makefiletarget inMakefilehas an incomplete list of.gypfiles for Node.js dependencies indeps, but also the ones that are listed are unconditional. If using any of the--shared-*configure options, it should be possible to still build Node.js if the corresponding directory underdepsis removed.Convert the explicit list of dependency
*.gypfiles for theout/Makefiletarget to a glob. This will pick up any toplevel.gypfiles for dependencies present indeps.