Revert "src: migrate String::Value to String::ValueView"
#55828
Merged
+29
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 45c6a9e.
nodejs-github-bot
added
c++
RedYetiDev
reviewed
Nov 12, 2024
Comment on lines
-248
to
+250
|
|
||
| TwoByteValue task_name_buffer(args.GetIsolate(), args[0]); | ||
| StringView task_name_view(*task_name_buffer, task_name_buffer.length()); | ||
| Local<String> task_name = args[0].As<String>(); | ||
| String::Value task_name_value(args.GetIsolate(), task_name); | ||
| StringView task_name_view(*task_name_value, task_name_value.length()); |
There was a problem hiding this comment.
Do we need a full revert, I feel like this part can stay the same?
There was a problem hiding this comment.
A full revert is easier to work with. You're free to make incremental changes after it.
There was a problem hiding this comment.
A good illustration of why atomic PRs should always be preferred.
|
Is there a test that can be added to ensure this doesn't happen again? |
|
I wasn't able to find a repro that doesn't involve webpack. |
gireeshpunathil
approved these changes
Nov 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55828 +/- ##
==========================================
- Coverage 88.41% 88.41% -0.01%
==========================================
Files 654 654
Lines 187811 187817 +6
Branches 36134 36132 -2
==========================================
+ Hits 166052 166056 +4
- Misses 15008 15011 +3
+ Partials 6751 6750 -1
|
aduh95
approved these changes
Nov 12, 2024
targos
added
request-ci
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Nov 12, 2024
|
Sorry for breaking this, everyone! Thanks for the speedy fix |
RedYetiDev
added
author ready
jakecastelli
approved these changes
Nov 13, 2024
benjamingr
approved these changes
Nov 13, 2024
jazelly
approved these changes
Nov 14, 2024
6 tasks
willxj36
added a commit
to willxj36/Interactive-Resume
that referenced
this pull request
Nov 16, 2024
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9f2885a |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 18, 2024
This reverts commit 45c6a9e. PR-URL: #55828 Fixes: #55826 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 45c6a9e.
Closes: #55826