Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: lint js in doc/**/*.md #55904

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tools: lint js in doc/**/*.md #55904

wants to merge 2 commits into from
+29 −31

Conversation

LiviaMedeiros
Copy link
Contributor

Not sure why it was in the ignore list.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 18, 2024
LiviaMedeiros
LiviaMedeiros commented Nov 18, 2024
View reviewed changes
eslint.config.mjs
'!doc/changelogs/CHANGELOG_V18.md',
'doc/changelogs/CHANGELOG_V23.md',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK we shouldn't make manual changes in changelogs, but if there's still a window to adjust CHANGELOG_V23 before v24.x release, we can add the //s here:

node/doc/changelogs/CHANGELOG_V23.md

Lines 179 to 183 in 746b17e

console.log(buffer.byteLength); 10
ab.resize(15);
console.log(buffer.byteLength); 15
ab.resize(5);
console.log(buffer.byteLength); 5

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have precedent for this (e.g. c6dabe3), AFAIK there are no issues with modifying the changelogs after the fact (it's not like someone is going to compare the hashes of the CHANGELOG files between main and the release tag)

@LiviaMedeiros LiviaMedeiros added wip Issues and PRs that are still a work in progress. doc Issues and PRs related to the documentations. labels Nov 18, 2024
@LiviaMedeiros LiviaMedeiros added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed wip Issues and PRs that are still a work in progress. labels Nov 18, 2024
mcollina
mcollina approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@cjihrig cjihrig cjihrig approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@LiviaMedeiros @nodejs-github-bot @mcollina @lpinca @anonrig @cjihrig @aduh95 @RedYetiDev