Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to past releases #7061

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix broken link to past releases #7061

merged 1 commit into from
Oct 1, 2024

Conversation

bmuenzenmeyer
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer commented Sep 27, 2024

Description

Simple pathing bug was causing a relative link instead of from root

Validation

Compare reported behavior in prod and the preview

  1. Go to https://nodejs-org-git-bmuenzenmeyer-patch-1-openjs.vercel.app/en/download/prebuilt-installer
  2. Click on "Node.js Releases"

Related Issues

closes #7060

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

closes #7060

Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner September 27, 2024 03:24
Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Sep 27, 2024 3:24am

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learn about <LinkWithArrow href="about/previous-releases">Node.js Releases</LinkWithArrow>
may need updating too?

@bmuenzenmeyer
Copy link
Collaborator Author

bmuenzenmeyer commented Sep 27, 2024

may need updating too?

I am struggling to find out to navigate to that page 😅
Is it dead code? 🤔

@mikeesto
Copy link
Member

I am struggling to find out to navigate to that page 😅
Is it dead code? 🤔

I think you're right - I can't see how you can navigate to it either. I used a free backlink checker and it does have some hits on things like node tutorials and guides, so perhaps worth keeping still

Copy link

github-actions bot commented Sep 30, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.47% (589/651) 76.29% (177/232) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.398s ⏱️

@ovflowd ovflowd added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit e16bc05 Oct 1, 2024
15 checks passed
@ovflowd ovflowd deleted the bmuenzenmeyer-patch-1 branch October 1, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Learn about Node.js Releases" refers to a non-existent page
3 participants