feat: add skip-to-content button #7235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
canerakdas
reviewed
Nov 16, 2024
| @@ -23,6 +24,15 @@ const WithNavBar: FC = () => { | |||
|
|
|||
| return ( | |||
| <div> | |||
| <Button | |||
There was a problem hiding this comment.
I think this should be a link instead of a button, something basic (like GitHub) could be considered for styling
| @@ -23,6 +24,15 @@ const WithNavBar: FC = () => { | |||
|
|
|||
| return ( | |||
| <div> | |||
| <Button | |||
| className={ | |||
| '!fixed left-0 m-3 -translate-y-16 p-3 !transition focus:translate-y-0' | |||
There was a problem hiding this comment.
the transitions should be motion-safe, and avoid adding important
|
Hmm. I didn't realize additional logic was leading besides just #-ing the element. I'll look into this on my own, but I'm closing this for now, as to not take the opportunity from someone else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a "Skip Navigation" button. There was no CSS file for the Navbar, so I used inline classes.
Validation
Visit the preview page, and without clicking any elements, press Tab.
Related Issues
Fixes #7220
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.