Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js 22.11.0 Windows x86 & ARM64 checksums seem to be incorrect #149

Closed
val1984 opened this issue Oct 30, 2024 · 5 comments
Closed

Node.js 22.11.0 Windows x86 & ARM64 checksums seem to be incorrect #149

val1984 opened this issue Oct 30, 2024 · 5 comments

Comments

@val1984
Copy link

val1984 commented Oct 30, 2024

Trying to contribute nodejs22 to ScoopInstaller/Versions, I ran into incorrect hashes in Node.js 22.11.0 SHASUMS256.txt.asc:

INFO: Hashes

Log of Output:

    Downloading https://nodejs.org/dist/v22.11.0/node-v22.11.0-win-x64.7z (20.3 MB)... 
    Downloading https://nodejs.org/dist/v22.11.0/node-v22.11.0-win-x86.7z (18.7 MB)... 
    Downloading https://nodejs.org/dist/v22.11.0/node-v22.11.0-win-arm64.7z (18.2 MB)... 
    nodejs22:  
    Mismatch found  
    	URL:		https://nodejs.org/dist/v22.11.0/node-v22.11.0-win-x86.7z 
    	First bytes:	37 7A BC AF 27 1C 00 04 
    	Expected:	ca0a274f1edc90005b1dc7ec22ec55dad1acc21320bc0be853065d69db2a5152 
    	Actual:		dec300137430fe59c5d1aaeeba7f58a1cc0daba6491eda72b8ef487564aae563 
    	URL:		https://nodejs.org/dist/v22.11.0/node-v22.11.0-win-arm64.7z 
    	First bytes:	37 7A BC AF 27 1C 00 04 
    	Expected:	55b491f3d73fdacf8cf43a2199e824abadda2c43a94780310baa526dc1d679e2 
    	Actual:		ccc1b437529098658cfd91b568c3f3f3672dc118dd531044d22e45515737a9af

Source
@val1984 val1984 changed the title Node.js 22.11.0 Windows x86 & ARM64 checksums are incorrect Node.js 22.11.0 Windows x86 & ARM64 checksums seem to be incorrect Oct 30, 2024
@val1984 val1984 mentioned this issue Oct 30, 2024
Merged
1 task
@targos
Copy link
Member

targos commented Oct 30, 2024

/cc @richardlau who promoted the release

@richardlau
Copy link
Member

I just tried this and get matches:

$ wget https://nodejs.org/dist/v22.11.0/node-v22.11.0-win-arm64.7z
--2024-10-30 14:04:24--  https://nodejs.org/dist/v22.11.0/node-v22.11.0-win-arm64.7z
Resolving nodejs.org (nodejs.org)... 104.20.22.46, 104.20.23.46, 2606:4700:10::6814:172e, ...
Connecting to nodejs.org (nodejs.org)|104.20.22.46|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 19065748 (18M) [application/x-7z-compressed]
Saving to: ‘node-v22.11.0-win-arm64.7z’

node-v22.11.0-win-arm64.7z                           100%[===================================================================================================================>]  18.18M  --.-KB/s    in 0.1s

2024-10-30 14:04:24 (190 MB/s) - ‘node-v22.11.0-win-arm64.7z’ saved [19065748/19065748]

$ wget https://nodejs.org/dist/v22.11.0/node-v22.11.0-win-x86.7z
--2024-10-30 14:04:27--  https://nodejs.org/dist/v22.11.0/node-v22.11.0-win-x86.7z
Resolving nodejs.org (nodejs.org)... 104.20.23.46, 104.20.22.46, 2606:4700:10::6814:162e, ...
Connecting to nodejs.org (nodejs.org)|104.20.23.46|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 19573460 (19M) [application/x-7z-compressed]
Saving to: ‘node-v22.11.0-win-x86.7z’

node-v22.11.0-win-x86.7z                             100%[===================================================================================================================>]  18.67M  --.-KB/s    in 0.07s

2024-10-30 14:04:27 (267 MB/s) - ‘node-v22.11.0-win-x86.7z’ saved [19573460/19573460]

$ wget https://nodejs.org/dist/latest-v22.x/SHASUMS256.txt.asc
--2024-10-30 14:04:33--  https://nodejs.org/dist/latest-v22.x/SHASUMS256.txt.asc
Resolving nodejs.org (nodejs.org)... 104.20.22.46, 104.20.23.46, 2606:4700:10::6814:172e, ...
Connecting to nodejs.org (nodejs.org)|104.20.22.46|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/plain]
Saving to: ‘SHASUMS256.txt.asc’

SHASUMS256.txt.asc                                       [ <=>                                                                                                                ]   4.55K  --.-KB/s    in 0s

2024-10-30 14:04:33 (56.6 MB/s) - ‘SHASUMS256.txt.asc’ saved [4659]

$ sha256sum -c SHASUMS256.txt.asc --ignore-missing
node-v22.11.0-win-arm64.7z: OK
node-v22.11.0-win-x86.7z: OK
sha256sum: WARNING: 19 lines are improperly formatted
$

@richardlau
Copy link
Member

FWIW https://ci.nodejs.org/job/validate-downloads/2706/console also agrees that the assets for 22.11.0 match their SHASUMS.

@richardlau
Copy link
Member

richardlau commented Oct 30, 2024 •
edited
Loading

Since this is in the release-cloudflare-worker repo, I tried downloading from R2 and got the same matches:

$ wget https://r2.nodejs.org/dist/v22.11.0/node-v22.11.0-win-x86.7z
--2024-10-30 14:12:27--  https://r2.nodejs.org/dist/v22.11.0/node-v22.11.0-win-x86.7z
Resolving r2.nodejs.org (r2.nodejs.org)... 104.20.22.46, 104.20.23.46, 2606:4700:10::6814:172e, ...
Connecting to r2.nodejs.org (r2.nodejs.org)|104.20.22.46|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 19573460 (19M) [application/octet-stream]
Saving to: ‘node-v22.11.0-win-x86.7z’

node-v22.11.0-win-x86.7z                             100%[===================================================================================================================>]  18.67M  25.7MB/s    in 0.7s

2024-10-30 14:12:28 (25.7 MB/s) - ‘node-v22.11.0-win-x86.7z’ saved [19573460/19573460]

$ wget https://r2.nodejs.org/dist/v22.11.0/node-v22.11.0-win-arm64.7z
--2024-10-30 14:12:40--  https://r2.nodejs.org/dist/v22.11.0/node-v22.11.0-win-arm64.7z
Resolving r2.nodejs.org (r2.nodejs.org)... 104.20.23.46, 104.20.22.46, 2606:4700:10::6814:162e, ...
Connecting to r2.nodejs.org (r2.nodejs.org)|104.20.23.46|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 19065748 (18M) [application/octet-stream]
Saving to: ‘node-v22.11.0-win-arm64.7z’

node-v22.11.0-win-arm64.7z                           100%[===================================================================================================================>]  18.18M  19.5MB/s    in 0.9s

2024-10-30 14:12:41 (19.5 MB/s) - ‘node-v22.11.0-win-arm64.7z’ saved [19065748/19065748]

$ wget https://r2.nodejs.org/dist/v22.11.0/SHASUMS256.txt.asc
--2024-10-30 14:13:36--  https://r2.nodejs.org/dist/v22.11.0/SHASUMS256.txt.asc
Resolving r2.nodejs.org (r2.nodejs.org)... 104.20.22.46, 104.20.23.46, 2606:4700:10::6814:172e, ...
Connecting to r2.nodejs.org (r2.nodejs.org)|104.20.22.46|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 4659 (4.5K) [application/pgp-keys]
Saving to: ‘SHASUMS256.txt.asc’

SHASUMS256.txt.asc.1                                 100%[===================================================================================================================>]   4.55K  --.-KB/s    in 0s

2024-10-30 14:13:36 (65.8 MB/s) - ‘SHASUMS256.txt.asc’ saved [4659/4659]

$ sha256sum -c SHASUMS256.txt.asc --ignore-missing
node-v22.11.0-win-arm64.7z: OK
node-v22.11.0-win-x86.7z: OK
sha256sum: WARNING: 19 lines are improperly formatted
$

@val1984
Copy link
Author

val1984 commented Oct 30, 2024

So sorry, I'm not sure what happened in the GHA run I linked to in my initial post. I checked locally and the hashes match. And latest run was successful too. I apologize for bothering you and thank you for the quick answer 🙂

@val1984 val1984 closed this as completed Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@targos @val1984 @richardlau