-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use same directory listing format as nginx #65
Conversation
c42ce71
to
559e284
Compare
559e284
to
da1da96
Compare
Never mind, just saw the linked issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nginx uses columns with fixed length:
50 chars for the file name
1 space
date
20 chars for the file size
The name is truncated if it's too long: https://direct.nodejs.org/download/test/
The size is written in bytes, without a unit
I'm not sure we should limit to 50 characters, I don't think this is an issue for us. |
@flakey5 can you also add an screenshot on some directory listings how it'd look like? |
We can try it. Also would love if dark theme kept working. |
266c781
to
d0d6a81
Compare
d0d6a81
to
907e9eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see what it looks like on staging.
How we deploy to staging? 🤔 |
Isn't it done automatically when the PR is merged on |
Oh yes, it is :) |
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Should I merge to test in staging? |
Quotes? (Single vs double) |
Yeah that appears to be the issue, thanks for catching! #76 |
This PR adopts similar directory listing structure as NGINX to keep existing crawlers and scripts working.