feat: disable FinalizationRegistry if NODE_V8_COVERAGE is set (#2304)

nodejs · Oct 3, 2023 · 7c2486d · 7c2486d
1 parent 4024468
commit 7c2486d
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/core/connect.js b/lib/core/connect.js
@@ -13,7 +13,9 @@ let tls // include tls conditionally since it is not always available
 // re-use is enabled.
 
 let SessionCache
-if (global.FinalizationRegistry) {
+// FIXME: remove workaround when the Node bug is fixed
+// https://github.com/nodejs/node/issues/49344#issuecomment-1741776308
+if (global.FinalizationRegistry && !process.env.NODE_V8_COVERAGE) {
   SessionCache = class WeakSessionCache {
     constructor (maxCachedSessions) {
       this._maxCachedSessions = maxCachedSessions