mark websocket WPTs as failing

nodejs · Dec 1, 2023 · a4c9af3 · a4c9af3
1 parent b5dcb40
commit a4c9af3
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/lib/websocket/connection.js b/lib/websocket/connection.js
@@ -261,6 +261,7 @@ function onSocketClose () {
   //    attribute initialized to the result of applying UTF-8
   //    decode without BOM to the WebSocket connection close
   //    reason.
+  // TODO: process.nextTick
   fireEvent('close', ws, CloseEvent, {
     wasClean, code, reason
   })

diff --git a/lib/websocket/util.js b/lib/websocket/util.js
@@ -182,6 +182,7 @@ function failWebsocketConnection (ws, reason) {
   }
 
   if (reason) {
+    // TODO: process.nextTick
     fireEvent('error', ws, ErrorEvent, {
       error: new Error(reason)
     })

diff --git a/test/wpt/status/websockets.status.json b/test/wpt/status/websockets.status.json
@@ -4,6 +4,18 @@
       "skip": true
     }
   },
+  "interfaces": {
+    "WebSocket": {
+      "close": {
+        "close-connecting-async.any.js": {
+          "note": "TODO - need to add route for handshake delay",
+          "fail": [
+            "close event should be fired asynchronously when WebSocket is connecting"
+          ]
+        }
+      }
+    }
+  },
   "Create-blocked-port.any.js": {
     "note": "TODO(@KhafraDev): investigate failure",
     "fail": [