correctly set if-none-match (#3933)

nodejs · Dec 8, 2024 · bfdfcc0 · bfdfcc0
1 parent cac18e1
commit bfdfcc0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/interceptor/cache.js b/lib/interceptor/cache.js
@@ -229,7 +229,7 @@ function handleResult (
     }
 
     if (result.etag) {
-      headers.etag = result.etag
+      headers['if-none-match'] = result.etag
     }
 
     if (result.vary) {

diff --git a/test/interceptors/cache.js b/test/interceptors/cache.js
@@ -155,6 +155,14 @@ describe('Cache Interceptor', () => {
     }).listen(0)
 
     const client = new Client(`http://localhost:${server.address().port}`)
+      .compose((dispatch) => {
+        return (opts, handler) => {
+          if (opts.headers) {
+            strictEqual(Object.prototype.hasOwnProperty.call(opts.headers, 'if-none-match'), false)
+          }
+          return dispatch(opts, handler)
+        }
+      })
       .compose(interceptors.cache())
 
     after(async () => {