simplify error and cause

[fedyk]

This relates to #2327. Due to rebase of changes from master to next, the changes looks weird. I decided to create a new clean MR.

Rationale

Since Node v16.9.0, Error supports cause property.

Changes

Replace Object.assign with new Error(.., { cause }).

Status

• I have read and agreed to the Developer's Certificate of Origin
• Tested
• Benchmarked (optional)
• Documented
• Review ready
• In review
• Merge ready

[mcollina]

I have a loose recall that v16.8 is what lambda deploys, so changing this would be detrimental.

[codecov-commenter]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b9d8368) 85.49% compared to head (e6b8379) 85.48%.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2347      +/-   ##
==========================================
- Coverage   85.49%   85.48%   -0.02%     
==========================================
  Files          76       76              
  Lines        6867     6867              
==========================================
- Hits         5871     5870       -1     
- Misses        996      997       +1     

Files	Coverage Δ
lib/fetch/body.js	97.67% <ø> (ø)
lib/fetch/index.js	85.05% <ø> (-0.18%)	⬇️
lib/fetch/response.js	95.83% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fedyk]

@mcollina thanks for your comment.

I believe you are referring to AWS Lambda. According to the docs, they support Node.js v16.x. Brief grep in the base nodejs image, shows that the current version is 16.20.2 (they probably keep the most recent version live).

[ronag]

Can we make a test for node 16?

[mcollina]

There is already one for node v16.8 in CI

[fedyk]

If support of v16.8 is important, then those changes are breaking due to cause only available in v16.9. I believe this MR can be closed for now.