Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(websocket): avoid toLowerCase call #2550

Closed
wants to merge 1 commit into from

Conversation

tsctx
Copy link
Member

@tsctx tsctx commented Dec 28, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

Attention: 157 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (0d5a0bd) 84.64%.
Report is 175 commits behind head on main.

Files Patch % Lines
lib/fetch/index.js 67.29% 52 Missing ⚠️
lib/fetch/util.js 34.66% 49 Missing ⚠️
lib/handler/RetryHandler.js 74.35% 30 Missing ⚠️
lib/api/readable.js 88.88% 5 Missing ⚠️
lib/compat/dispatcher-weakref.js 28.57% 5 Missing ⚠️
lib/fetch/headers.js 90.19% 5 Missing ⚠️
lib/client.js 93.44% 4 Missing ⚠️
lib/core/util.js 95.55% 2 Missing ⚠️
lib/fetch/request.js 92.00% 2 Missing ⚠️
lib/core/request.js 98.21% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2550      +/-   ##
==========================================
- Coverage   85.54%   84.64%   -0.91%     
==========================================
  Files          76       80       +4     
  Lines        6858     7240     +382     
==========================================
+ Hits         5867     6128     +261     
- Misses        991     1112     +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handshake performance doesn't matter because you rarely connect to a websocket server (lpinca mentioned this to me when I implemented websocket). This is optimizing (is it?) for a very, very cold path.

@tsctx
Copy link
Member Author

tsctx commented Dec 28, 2023

Thanks for the explanation. I agree with you.

@tsctx tsctx closed this Dec 28, 2023
@tsctx tsctx deleted the perf/websocket-avoid-tolowercase branch December 28, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants