investigate warning

lib/web/fetch/request.js

@@ -31,6 +31,9 @@ const { getMaxListeners, setMaxListeners, defaultMaxListeners } = require('node:
 
 const kAbortController = Symbol('abortController')
 
+// This is only available in node >= v19.9.0
+const hasGetMaxListeners = typeof getMaxListeners === 'function'
+
 const requestFinalizer = new FinalizationRegistry(({ signal, abort }) => {
   signal.removeEventListener('abort', abort)
 })
@@ -424,15 +427,16 @@ class Request {
         const acRef = new WeakRef(ac)
         const abort = buildAbort(acRef)
 
-        // Third-party AbortControllers may not work with these.
-        // See, https://github.com/nodejs/undici/pull/1910#issuecomment-1464495619.
-        try {
-          // If the max amount of listeners is equal to the default, increase it
-          // This is only available in node >= v19.9.0
-          if (typeof getMaxListeners === 'function' && getMaxListeners(signal) === defaultMaxListeners) {
-            setMaxListeners(1500, signal)
-          }
-        } catch {}
+        if (hasGetMaxListeners) {
+          // Third-party AbortControllers may not work with these.
+          // See, https://github.com/nodejs/undici/pull/1910#issuecomment-1464495619.
+          try {
+            // If the max amount of listeners is equal to the default, increase it
+            if (getMaxListeners(signal) === defaultMaxListeners) {
+              setMaxListeners(1500, signal)
+            }
+          } catch {}
+        }
 
         util.addAbortListener(signal, abort)
         // The third argument must be a registry key to be unregistered.

test/fetch/long-lived-abort-controller.js

@@ -1,28 +1,43 @@
 'use strict'
 
-const http = require('node:http')
-const { fetch } = require('../../')
-const { once } = require('events')
+const { fork } = require('node:child_process')
+const { resolve: pathResolve } = require('node:path')
 const { test } = require('node:test')
-const { closeServerAsPromise } = require('../utils/node-http')
-const { strictEqual } = require('node:assert')
+const { fetch } = require('../../')
+const { strictEqual, fail } = require('node:assert')
 
-// const isNode18 = process.version.startsWith('v18')
+const isNode18 = process.version.startsWith('v18')
 
-test('long-lived-abort-controller', { skip: true }, async (t) => {
-  const server = http.createServer((req, res) => {
-    res.writeHead(200, { 'Content-Type': 'text/plain' })
-    res.write('Hello World!')
-    res.end()
-  }).listen(0)
+test('long-lived-abort-controller', { skip: isNode18 }, async (t) => {
+  // Spawn a server in a new process to avoid effects from the blocking event loop
+  const {
+    serverProcess,
+    address
+  } = await new Promise((resolve, reject) => {
+    const childProcess = fork(
+      pathResolve(__dirname, '../utils/hello-world-server.js'),
+      [],
+      { windowsHide: true }
+    )
 
-  await once(server, 'listening')
+    childProcess.on('message', (address) => {
+      resolve({
+        serverProcess: childProcess,
+        address
+      })
+    })
+    childProcess.on('error', err => {
+      reject(err)
+    })
+  })
 
-  t.after(closeServerAsPromise(server))
+  t.after(() => {
+    serverProcess.kill('SIGKILL')
+  })
 
-  let warningEmitted = false
-  function onWarning () {
-    warningEmitted = true
+  let emittedWarning = null
+  function onWarning (value) {
+    emittedWarning = value
   }
   process.on('warning', onWarning)
   t.after(() => {
@@ -36,13 +51,17 @@
   // Unfortunately we are relying on GC and implementation details here.
   for (let i = 0; i < 2000; i++) {
     // make request
-    const res = await fetch(`http://localhost:${server.address().port}`, {
+    const res = await fetch(address, {
       signal: controller.signal
     })
 
     // drain body
     await res.text()
   }
 
-  strictEqual(warningEmitted, false)
+  if (emittedWarning !== null) {
+    fail(emittedWarning)
+  } else {
+    strictEqual(emittedWarning, null)
+  }
 })

test/issue-3410.js

@@ -17,7 +17,7 @@ describe('https://github.com/nodejs/undici/issues/3410', () => {
       address
     } = await new Promise((resolve, reject) => {
       const childProcess = fork(
-        pathResolve(__dirname, './utils/hello-world-server.js'),
+        pathResolve(__dirname, './utils/hello-world-server-delayed.js'),
         [],
         { windowsHide: true }
       )
@@ -56,7 +56,7 @@ describe('https://github.com/nodejs/undici/issues/3410', () => {
       address
     } = await new Promise((resolve, reject) => {
       const childProcess = fork(
-        pathResolve(__dirname, './utils/hello-world-server.js'),
+        pathResolve(__dirname, './utils/hello-world-server-delayed.js'),
         [],
         { windowsHide: true }
       )

test/utils/hello-world-server-delayed.js

@@ -0,0 +1,30 @@
+'use strict'
+
+const { createServer } = require('node:http')
+const hostname = '127.0.0.1'
+
+const server = createServer(async (req, res) => {
+  res.statusCode = 200
+  res.setHeader('Content-Type', 'text/plain')
+
+  await sendInDelayedChunks(res, 'Hello World', 125)
+  res.end()
+})
+
+async function sendInDelayedChunks (res, payload, delay) {
+  const chunks = payload.split('')
+
+  for (const chunk of chunks) {
+    await new Promise(resolve => setTimeout(resolve, delay))
+
+    res.write(chunk)
+  }
+}
+
+server.listen(0, hostname, () => {
+  if (process.send) {
+    process.send(`http://${hostname}:${server.address().port}/`)
+  } else {
+    console.log(`http://${hostname}:${server.address().port}/`)
+  }
+})

test/utils/hello-world-server.js

@@ -6,21 +6,9 @@ const hostname = '127.0.0.1'
 const server = createServer(async (req, res) => {
   res.statusCode = 200
   res.setHeader('Content-Type', 'text/plain')
-
-  await sendInDelayedChunks(res, 'Hello World', 125)
-  res.end()
+  res.end('Hello World')
 })
 
-async function sendInDelayedChunks (res, payload, delay) {
-  const chunks = payload.split('')
-
-  for (const chunk of chunks) {
-    await new Promise(resolve => setTimeout(resolve, delay))
-
-    res.write(chunk)
-  }
-}
-
 server.listen(0, hostname, () => {
   if (process.send) {
     process.send(`http://${hostname}:${server.address().port}/`)