Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ember directory dependencies is breaking the build #369

Open
pnaik1 opened this issue Aug 16, 2022 · 9 comments
Open

Updating ember directory dependencies is breaking the build #369

pnaik1 opened this issue Aug 16, 2022 · 9 comments
Labels
bug Something isn't working

Comments

@pnaik1
Copy link
Member

pnaik1 commented Aug 16, 2022

the ember directory worked fine before the updation .. The error occured when I updated the client's package.json file and started the server

Screenshot from 2022-08-16 17-36-49

@pnaik1 pnaik1 changed the title Updating of ember directory dependencies is breaking the build Updating ember directory dependencies is breaking the build Aug 16, 2022
@helio-frota helio-frota self-assigned this Aug 16, 2022
@helio-frota
Copy link
Member

@pnaik1 thanks for reporting this.

So made some tests with this and looks like we have a situation with this example related to the jquery.

[1] Setting the `jquery-integration` optional feature flag to `true` was deprecated in Ember 3.x and removed in Ember 4.0.0. You must add the `@ember/optional-features` addon and set this feature to `false`.
[1] 
[1] For more information, see the deprecation guide: https://deprecations.emberjs.com/v3.x/#toc_optional-feature-jquery-integration

Then when we disable this we get the following error:

[1] /home/lm/code/opossum-examples/ember/client/ember-opossum/templates/application.js: Cannot read properties of undefined (reading 'visitor')TypeError: /home/lm/code/opossum-examples/ember/client/ember-opossum/templates/application.js: Cannot read properties of undefined (reading 'visitor')

@helio-frota
Copy link
Member

As a feedback, we are waiting a response from Luke that is on PTO about this specific example.

@helio-frota helio-frota removed their assignment Aug 18, 2022
@helio-frota helio-frota added the bug Something isn't working label Aug 18, 2022
@lholmquist
Copy link
Contributor

I'm back from PTO now, so i'll put this towards the top of the list

@helio-frota
Copy link
Member

thanks!

@lholmquist
Copy link
Contributor

@pnaik1 have you tried to follow the recommendations of the error message:

Screen Shot 2022-09-06 at 11 16 13 AM

Ember also has a guide on how to do upgrades of their apps that might help, https://cli.emberjs.com/release/basic-use/upgrading/#upgradinganemberappitself

@pacostas
Copy link
Member

@pnaik1 Which steps did you follow in order to upgrade client's dependencies? I'm trying to reproduce on my pc

@pnaik1
Copy link
Member Author

pnaik1 commented Oct 17, 2022

@pacostas I have used npm outdated command to check latest version and manually changed the dependencies

@pacostas
Copy link
Member

@pnaik1 In which dependency did this error appeared?

@helio-frota
Copy link
Member

@pacostas hi, I don't remember exactly which dependency I went a bit further and I found this #369 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants