Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change property configuration for hidden referenced fields #655

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

a-crea
Copy link
Contributor

@a-crea a-crea commented Nov 12, 2024

This PR solves issue #616

@gappc
Copy link
Collaborator

gappc commented Nov 28, 2024

@a-crea thank you for the improvements in this PR

I tested it and while it works fine in most circumstances, there seem to be some bugs around the handling of array data. Array data is not always shown when the "Load referenced attributes" toggle is deselected. I found that problem appear mostly when logged in, because then, the data from ODH is more complete. You can find the steps to reproduce below the images.

Toggle enabled => Boardings shown

image

Toggle disabled => no Boardings shown

image

Steps to reproduce:

  1. login to the Data Browser
  2. open http://localhost:3000/dataset/detail/tourism/v1/Accommodation/5E4BEFD440200CE4732A7FA30897C402
  3. toggle the "Load referenced attributes"

@a-crea could you please take a look at this?

@a-crea
Copy link
Contributor Author

a-crea commented Dec 10, 2024

Hi @gappc, thanks for the report.
I’ve made some adjustments, which should cover all cases. An empty text message has also been added to arraycell and will be populated in cases where no value is set for reference fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants