-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Co-authored-by: Khashayar Barooti <khashayar.baroot@epfl.ch>
- Loading branch information
1 parent
35bf983
commit 2ca8b1a
Showing
11 changed files
with
164 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
name: Benchmarks | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
|
||
jobs: | ||
test: | ||
name: Benchmark library | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout sources | ||
uses: actions/checkout@v4 | ||
|
||
- name: Install Nargo | ||
uses: noir-lang/noirup@v0.1.3 | ||
with: | ||
toolchain: 1.0.0-beta.0 | ||
|
||
- name: Install bb | ||
run: | | ||
npm install -g bbup | ||
bbup -nv 1.0.0-beta.0 | ||
sudo apt install libc++-dev | ||
- name: Build Noir benchmark programs | ||
run: nargo export | ||
|
||
- name: Generate gates report | ||
run: ./scripts/build-gates-report.sh | ||
env: | ||
BACKEND: /home/runner/.bb/bb | ||
|
||
- name: Compare gates reports | ||
id: gates_diff | ||
uses: noir-lang/noir-gates-diff@1931aaaa848a1a009363d6115293f7b7fc72bb87 | ||
with: | ||
report: gates_report.json | ||
summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%) | ||
|
||
- name: Add gates diff to sticky comment | ||
if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target' | ||
uses: marocchino/sticky-pull-request-comment@v2 | ||
with: | ||
# delete the comment in case changes no longer impact circuit sizes | ||
delete: ${{ !steps.gates_diff.outputs.markdown }} | ||
message: ${{ steps.gates_diff.outputs.markdown }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,4 @@ | ||
target | ||
.vscode/launch.json | ||
export/* | ||
gates_report.json |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
#!/usr/bin/env bash | ||
set -e | ||
|
||
BACKEND=${BACKEND:-bb} | ||
|
||
cd $(dirname "$0")/../ | ||
|
||
artifacts_path="./export" | ||
artifacts=$(ls $artifacts_path) | ||
|
||
echo "{\"programs\": [" > gates_report.json | ||
|
||
# Bound for checking where to place last parentheses | ||
NUM_ARTIFACTS=$(ls -1q "$artifacts_path" | wc -l) | ||
|
||
ITER="1" | ||
for artifact in $artifacts; do | ||
ARTIFACT_NAME=$(basename "$artifact") | ||
|
||
GATES_INFO=$($BACKEND gates -b "$artifacts_path/$artifact") | ||
MAIN_FUNCTION_INFO=$(echo $GATES_INFO | jq -r '.functions[0] | .name = "main"') | ||
echo "{\"package_name\": \"$ARTIFACT_NAME\", \"functions\": [$MAIN_FUNCTION_INFO]" >> gates_report.json | ||
|
||
if (($ITER == $NUM_ARTIFACTS)); then | ||
echo "}" >> gates_report.json | ||
else | ||
echo "}, " >> gates_report.json | ||
fi | ||
|
||
ITER=$(( $ITER + 1 )) | ||
done | ||
|
||
echo "]}" >> gates_report.json | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
use crate::bignum::BigNum; | ||
|
||
use crate::fields::bn254Fq::BN254_Fq_Params; | ||
use crate::fields::U256::U256Params; | ||
|
||
// the types we will be benchmarking | ||
|
||
type Fq = BigNum<3, 254, BN254_Fq_Params>; | ||
type BN256 = BigNum<3, 257, U256Params>; | ||
|
||
// type Fq | ||
// type BN256 | ||
// type BN381 | ||
// type BN2048 | ||
#[export] | ||
fn bench_add_Fq(a: Fq, b: Fq) -> Fq { | ||
a + b | ||
} | ||
|
||
#[export] | ||
fn bench_sub_Fq(a: Fq, b: Fq) -> Fq { | ||
a - b | ||
} | ||
|
||
#[export] | ||
fn bench_mul_Fq(a: Fq, b: Fq) -> Fq { | ||
a * b | ||
} | ||
|
||
#[export] | ||
fn bench_div_Fq(a: Fq, b: Fq) -> Fq { | ||
a / b | ||
} | ||
|
||
#[export] | ||
fn bench_add_BN256(a: BN256, b: BN256) -> BN256 { | ||
a + b | ||
} | ||
|
||
#[export] | ||
fn bench_sub_BN256(a: BN256, b: BN256) -> BN256 { | ||
a - b | ||
} | ||
|
||
#[export] | ||
fn bench_mul_BN256(a: BN256, b: BN256) -> BN256 { | ||
a * b | ||
} | ||
|
||
#[export] | ||
fn bench_div_BN256(a: BN256, b: BN256) -> BN256 { | ||
a / b | ||
} | ||
|
||
#[export] | ||
fn bench_from_field_Fq(a: Field) -> Fq { | ||
Fq::from(a) | ||
} | ||
|
||
#[export] | ||
fn bench_from_field_BN256(a: Field) -> BN256 { | ||
BN256::from(a) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
mod bignum_benchmarks; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,6 @@ pub use runtime_bignum::RuntimeBigNum; | |
|
||
// Tests | ||
mod tests; | ||
|
||
// Benchmarks | ||
mod benchmarks; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -815,4 +815,3 @@ fn test_from_field_3_digits() { | |
}; | ||
assert(result == expected); | ||
} | ||
|