From 9783ce42892129575995ab316a1787ce3736b904 Mon Sep 17 00:00:00 2001 From: TomAFrench Date: Thu, 29 Aug 2024 17:23:36 +0000 Subject: [PATCH] chore: add a canary for tests failing on nightly releases of nargo --- .github/NIGHTLY_CANARY_DIED.md | 8 ++++++ .github/workflows/nightly-canary.yml | 40 ++++++++++++++++++++++++++++ .github/workflows/test.yml | 10 ++++--- 3 files changed, 55 insertions(+), 3 deletions(-) create mode 100644 .github/NIGHTLY_CANARY_DIED.md create mode 100644 .github/workflows/nightly-canary.yml diff --git a/.github/NIGHTLY_CANARY_DIED.md b/.github/NIGHTLY_CANARY_DIED.md new file mode 100644 index 00000000..f72f3e1b --- /dev/null +++ b/.github/NIGHTLY_CANARY_DIED.md @@ -0,0 +1,8 @@ +--- +title: "Tests fail on latest Nargo nightly release" +assignees: TomAFrench +--- + +The tests on this Noir project have started failing when using the latest nightly release of the Noir compiler. This likely means that there have been breaking changes for which this project needs to be updated to take into account. + +Check the [{{env.WORKFLOW_NAME}}]({{env.WORKFLOW_URL}}) workflow for details. \ No newline at end of file diff --git a/.github/workflows/nightly-canary.yml b/.github/workflows/nightly-canary.yml new file mode 100644 index 00000000..ddacb4df --- /dev/null +++ b/.github/workflows/nightly-canary.yml @@ -0,0 +1,40 @@ +name: Noir Nightly Canary + +on: + schedule: + # Run a check at 9 AM UTC + - cron: "0 9 * * *" + +env: + CARGO_TERM_COLOR: always + +jobs: + test: + name: Test on Nargo ${{matrix.toolchain}} + runs-on: ubuntu-latest + steps: + - name: Checkout sources + uses: actions/checkout@v4 + + - name: Install Nargo + uses: noir-lang/noirup@v0.1.3 + with: + toolchain: nightly + + - name: Run Noir tests + run: nargo test + + - name: Run formatter + run: nargo fmt --check + + - name: Alert on dead links + uses: JasonEtco/create-an-issue@v2 + if: ${{ failure() }} + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + WORKFLOW_NAME: ${{ github.workflow }} + WORKFLOW_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} + with: + update_existing: true + filename: .github/NIGHTLY_CANARY_DIED.md + \ No newline at end of file diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 842e6615..8e58c35f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,11 +8,15 @@ on: env: CARGO_TERM_COLOR: always - NARGO_VERSION: 0.32.0 jobs: test: + name: Test on Nargo ${{matrix.toolchain}} runs-on: ubuntu-latest + strategy: + fail-fast: false + matrix: + toolchain: [nightly, 0.32.0] steps: - name: Checkout sources uses: actions/checkout@v4 @@ -20,7 +24,7 @@ jobs: - name: Install Nargo uses: noir-lang/noirup@v0.1.3 with: - toolchain: $NARGO_VERSION + toolchain: ${{ matrix.toolchain }} - name: Run Noir tests run: nargo test @@ -34,7 +38,7 @@ jobs: - name: Install Nargo uses: noir-lang/noirup@v0.1.3 with: - toolchain: $NARGO_VERSION + toolchain: 0.32.0 - name: Run formatter run: nargo fmt --check \ No newline at end of file