Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated README for BigNum lib #85

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

ewynx
Copy link
Contributor

@ewynx ewynx commented Dec 21, 2024

Description

Replacement of previously added documentation here as requested by @jzaki.

Problem*

Resolves

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link

@jzaki jzaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits for clarity, otherwise looks good

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@TomAFrench
Copy link
Member

Is this PR still active?

@ewynx ewynx changed the title Updated README for BigNum lib chore: Updated README for BigNum lib Jan 6, 2025
@ewynx
Copy link
Contributor Author

ewynx commented Jan 6, 2025

@jzaki added fixes, except for 1 which is from the original text afaik. Also added chore: to the PR title

README.md Outdated Show resolved Hide resolved
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ewynx and others added 3 commits January 6, 2025 14:15
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
@jzaki
Copy link

jzaki commented Jan 6, 2025

@TomAFrench I'll leave it to you to merge if you're happy with it now.

@jzaki jzaki merged commit 241c26d into noir-lang:main Jan 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants