-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Updated README for BigNum lib #85
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzaki
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nits for clarity, otherwise looks good
Is this PR still active? |
ewynx
changed the title
Updated README for BigNum lib
chore: Updated README for BigNum lib
Jan 6, 2025
@jzaki added fixes, except for 1 which is from the original text afaik. Also added |
TomAFrench
reviewed
Jan 6, 2025
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
TomAFrench
reviewed
Jan 6, 2025
TomAFrench
reviewed
Jan 6, 2025
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
@TomAFrench I'll leave it to you to merge if you're happy with it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacement of previously added documentation here as requested by @jzaki.
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmt
on default settings.