Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow the exports for noir_js #3078

Closed
signorecello opened this issue Oct 10, 2023 · 0 comments
Closed

Narrow the exports for noir_js #3078

signorecello opened this issue Oct 10, 2023 · 0 comments
Labels
enhancement New feature or request js Noir's JavaScript packages
Milestone

Comments

@signorecello
Copy link
Contributor

Problem

As part of #3044 we decided to initially export everything from noirc_abi and acvm_js in order to keep the benefits of versioning.

However we should see which methods are needed to be exported, to avoid simply re-exporting the import, as discussed in that thread

Happy Case

NoirJS would only export methods that are used elsewhere, like acvm's generateWitness, so we keep some control over what's given to the Noir app developer.

Alternatives Considered

See #3044 for alternatives and their discussions

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@signorecello signorecello added the enhancement New feature or request label Oct 10, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 10, 2023
@Savio-Sou Savio-Sou added the js Noir's JavaScript packages label Oct 10, 2023
@kevaundray kevaundray added this to the 1.0 milestone Jan 15, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request js Noir's JavaScript packages
Projects
Archived in project
Development

No branches or pull requests

3 participants