Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entries to ACVM changelog get added to every version instead of just the version in which they are made. #3604

Open
TomAFrench opened this issue Nov 28, 2023 · 0 comments
Open

Entries to ACVM changelog get added to every version instead of just the version in which they are made. #3604

TomAFrench opened this issue Nov 28, 2023 · 0 comments
Labels
bug Something isn't working CI good first issue Good for newcomers

Comments

@TomAFrench
Copy link
Member

TomAFrench commented Nov 28, 2023 •
edited
Loading

Expected Behavior

A PR should only appear once in the changelog for ACVM

Bug

See: https://github.com/noir-lang/noir/blob/master/acvm-repo/CHANGELOG.md

acvm_js: Export black box solver functions (https://github.com/noir-lang/noir/issues/2812) ([da8a98e](https://github.com/noir-lang/noir/commit/da8a98ed312fe69cb0bdb8f9d0a70ee7a981398f)) appears 8 times.

Looking at #3603 we can see that the pending entries don't get cleared out after we make a release
@TomAFrench TomAFrench added the bug Something isn't working label Nov 28, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Nov 28, 2023
@TomAFrench TomAFrench added the CI label Nov 28, 2023
@TomAFrench TomAFrench mentioned this issue Nov 29, 2023
Closed
@kevaundray kevaundray added this to the 1.0 milestone Jan 15, 2024
@TomAFrench TomAFrench mentioned this issue Apr 20, 2024
Closed
@Savio-Sou Savio-Sou added the good first issue Good for newcomers label Apr 22, 2024
@TomAFrench TomAFrench removed this from the 1.0 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CI good first issue Good for newcomers
Projects
Noir
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TomAFrench @kevaundray @Savio-Sou