Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a .devcontainer.json file with rust support #3093

Closed
wants to merge 1 commit into from

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

I've been using a github codespace to review some PRs from external contributors recently. One issue I've been running into is that the default codespace image doesn't have rust installed so I need to install it each time.

This PR sets the codespace to use an image which installs rust by default to avoid this step.

Relevant links:
https://docs.github.com/en/codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration/introduction-to-dev-containers#about-dev-containers

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from kobyhallx October 10, 2023 21:42
@TomAFrench TomAFrench marked this pull request as draft October 11, 2023 00:00
@TomAFrench
Copy link
Member Author

This image doesn't have yarn, etc. by default so this needs to be added.

@TomAFrench TomAFrench force-pushed the tf/codespace-devcontainer branch from 85c5c3d to 7ea972c Compare October 11, 2023 08:33
@kobyhallx
Copy link
Contributor

This was previously attempted this way:
feat: nix based devncontainer #3097

let's discuss which would be most universal?

@TomAFrench
Copy link
Member Author

Closing in favour of #3097

@TomAFrench TomAFrench closed this Oct 11, 2023
@TomAFrench TomAFrench deleted the tf/codespace-devcontainer branch October 16, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants