Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add constructor formatter #3107

Closed
wants to merge 12 commits into from
Closed

chore: add constructor formatter #3107

wants to merge 12 commits into from

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Oct 11, 2023 •
edited
Loading

Description

Problem*

Resolves #2993

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench
Copy link
Member

I think this is another case which we want to hold off on implementing until we can place line breaks sensibly.

kevaundray
kevaundray approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't have this enabled by default -- I think its fine to merge in something which will reliably format constructors and we can iterate towards something that we want

kevaundray
kevaundray suggested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry didn't see the plain::

@jonybur jonybur requested a review from kevaundray October 12, 2023 09:09
@kevaundray kevaundray closed this Oct 30, 2023
@kevaundray kevaundray deleted the jb-constructor-formatter branch October 30, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher left review comments

@kevaundray kevaundray Awaiting requested review from kevaundray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Epic: Complete Noir formatter implementation
4 participants
@jonybur @TomAFrench @jfecher @kevaundray