Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add check links #3499

Closed
wants to merge 2 commits into from
Closed

chore: add check links #3499

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 16, 2023

Description

chore: add check links

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@ghost
Copy link
Author

ghost commented Nov 16, 2023

@signorecello, to fix this error, how can it be done?
image

@signorecello
Copy link
Contributor

let me try to reproduce... damn docs workflow...

@signorecello
Copy link
Contributor

can't reproduce, seems like your branch is out of date... I'm also wondering why are you using untitaker/hyperlink, it checks for broken links but that's already done by docusaurus build...

@ghost
Copy link
Author

ghost commented Nov 23, 2023

We had non-working links; I didn't know that there's already a check in Docusaurus build. Probably because the workflow is triggered only if the documentation is being edited, we sometimes miss such moments.

@ghost
Copy link
Author

ghost commented Nov 23, 2023

#3498 but now falls for another reason

@signorecello
Copy link
Contributor

Yep this one solves it #3545 👍 appreciate if you'd want to have a look at it

@ghost ghost closed this Nov 27, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant