-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: require trait primitive functions/calls to have their trait in scope #6901
Open
asterite
wants to merge
30
commits into
master
Choose a base branch
from
ab/trait-functions-in-scope-for-primitives
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-be-in-scope-for-methods
Peak Memory Sample
|
Compilation Report
|
5 tasks
Execution Report
|
Compilation Memory Report
|
Execution Memory Report
|
TomAFrench
force-pushed
the
ab/trait-functions-in-scope-for-primitives
branch
from
January 7, 2025 21:19
e6b2286
to
7a33518
Compare
Base automatically changed from
ab/require-trait-to-be-in-scope-for-methods
to
master
January 8, 2025 10:49
…tions-in-scope-for-primitives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on top of #6895
Problem
Part of #6864
Summary
Similar to the previous PRs but this time for primitive types (
Field::foo()
andfield.foo()
). In realityField::foo()
already worked before this PR (as a result of some previous PR) but I added tests to make sure that's the case.This PR also introduces a refactor: previously methods were kept in two places, one for structs and one for everything else (keyed under
TypeMethodKey
). Now they are all in a single place, and there's a newTypeMethodKey
variant for structs. This greatly simplifies/unifies the code.Additional Context
Documentation
Check one:
PR Checklist
cargo fmt
on default settings.