fix: Start RC at 1 again

[jfecher]

Description

Problem*

Resolves #6763... again

Summary*

No fixes yet, just wanted to see CI differences for now

Edit: This no longer fails on the original test_secp256r1_offset_generators test of noir_bigcurve...

Additional Context

Documentation*

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[github-actions]

Changes to Brillig bytecode sizes

Generated at commit: e9552f6af8421ec5cfc56d7b27523011ef645edc, compared to commit: 50647a6448f86faec59660f0ea96bc3d10559d8c

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
aes128_encrypt	-9 ✅	-1.63%
keccak256	-39 ✅	-1.78%
brillig_cow_assign	-3 ✅	-2.13%
conditional_regression_661	-3 ✅	-2.36%
regression_4202	-3 ✅	-2.40%
fold_call_witness_condition	-3 ✅	-2.61%
regression_bignum	-12 ✅	-3.61%

---

Full diff report 👇

Program	Brillig opcodes (+/-)	%
regression_5252	4,591 (-3)	-0.07%
u128	2,754 (-3)	-0.11%
slice_dynamic_index	2,504 (-3)	-0.12%
nested_array_dynamic	2,454 (-3)	-0.12%
poseidonsponge_x5_254	4,248 (-6)	-0.14%
poseidon_bn254_hash	5,413 (-12)	-0.22%
poseidon_bn254_hash_width_3	5,413 (-12)	-0.22%
strings	914 (-3)	-0.33%
sha256_var_size_regression	1,720 (-6)	-0.35%
regression_4449	748 (-3)	-0.40%
array_to_slice	715 (-3)	-0.42%
debug_logs	5,124 (-24)	-0.47%
hashmap	21,690 (-108)	-0.50%
regression_6674_3	552 (-3)	-0.54%
regression	939 (-6)	-0.63%
sha256_brillig_performance_regression	1,650 (-12)	-0.72%
uhashmap	13,884 (-117)	-0.84%
sha2_byte	2,743 (-24)	-0.87%
poseidon2	332 (-3)	-0.90%
bench_2_to_17	325 (-3)	-0.91%
sha256_regression	6,838 (-66)	-0.96%
ecdsa_secp256k1	899 (-9)	-0.99%
simple_shield	899 (-9)	-0.99%
array_dynamic_nested_blackbox_input	892 (-9)	-1.00%
wildcard_type	295 (-3)	-1.01%
conditional_1	1,176 (-12)	-1.01%
fold_2_to_17	578 (-6)	-1.03%
regression_struct_array_conditional	570 (-6)	-1.04%
brillig_cow_regression	2,143 (-24)	-1.11%
slice_loop	266 (-3)	-1.12%
fold_numeric_generic_poseidon	754 (-9)	-1.18%
no_predicates_numeric_generic_poseidon	754 (-9)	-1.18%
regression_6674_2	247 (-3)	-1.20%
regression_6674_1	244 (-3)	-1.21%
ram_blowup_regression	957 (-12)	-1.24%
fold_complex_outputs	475 (-6)	-1.25%
reference_counts	467 (-6)	-1.27%
bigint	2,165 (-30)	-1.37%
slices	2,156 (-30)	-1.37%
databus_two_calldata	211 (-3)	-1.40%
sha256_var_padding_regression	5,051 (-72)	-1.41%
to_be_bytes	209 (-3)	-1.42%
conditional_regression_short_circuit	1,246 (-18)	-1.42%
pedersen_commitment	206 (-3)	-1.44%
6	1,173 (-18)	-1.51%
7_function	570 (-9)	-1.55%
brillig_pedersen	556 (-9)	-1.59%
pedersen_check	556 (-9)	-1.59%
sha256_var_witness_const_regression	1,287 (-21)	-1.61%
pedersen_hash	367 (-6)	-1.61%
brillig_oracle	364 (-6)	-1.62%
sha256	2,365 (-39)	-1.62%
aes128_encrypt	543 (-9)	-1.63%
keccak256	2,158 (-39)	-1.78%
brillig_cow_assign	138 (-3)	-2.13%
conditional_regression_661	124 (-3)	-2.36%
regression_4202	122 (-3)	-2.40%
fold_call_witness_condition	112 (-3)	-2.61%
regression_bignum	320 (-12)	-3.61%

[github-actions]

Execution Report

Program	Execution Time	%
sha256_regression	0.100s	0%
regression_4709	0.001s	0%
ram_blowup_regression	0.578s	-1%
rollup-root	0.124s	-1%
rollup-block-merge	0.125s	-4%
rollup-base-public	2.490s	0%
rollup-base-private	1.670s	-2%
private-kernel-tail	0.023s	0%
private-kernel-reset	0.391s	0%
private-kernel-inner	0.117s	0%

[github-actions]

Compilation Report

Program	Compilation Time	%
sha256_regression	1.312s	-3%
regression_4709	0.781s	0%
ram_blowup_regression	14.840s	-2%
rollup-root	3.650s	-14%
rollup-block-merge	3.690s	-4%
rollup-base-public	36.500s	-2%
rollup-base-private	19.700s	0%
private-kernel-tail	1.029s	-2%
private-kernel-reset	6.766s	-4%
private-kernel-inner	2.094s	-6%
noir-contracts	84.300s	-2%

[github-actions]

Execution Memory Report

Program	Peak Memory
keccak256	74.61M
workspace	123.71M
regression_4709	315.93M
ram_blowup_regression	512.47M
rollup-base-public	1.18G
rollup-base-private	831.51M
private-kernel-tail	181.99M
private-kernel-reset	255.56M
private-kernel-inner	215.17M

[github-actions]

Compilation Memory Report

Program	Peak Memory
keccak256	78.50M
workspace	123.71M
regression_4709	422.91M
ram_blowup_regression	1.58G
rollup-base-public	2.80G
rollup-base-private	1.86G
private-kernel-tail	201.95M
private-kernel-reset	716.55M
private-kernel-inner	292.22M

[jfecher]

So oddly this now passes on test_secp256r1_offset_generators despite no changes being made 😕

[github-actions]

Changes to number of Brillig opcodes executed

Generated at commit: e9552f6af8421ec5cfc56d7b27523011ef645edc, compared to commit: 50647a6448f86faec59660f0ea96bc3d10559d8c

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
databus_two_calldata	-47 ✅	-10.54%
brillig_oracle	-318 ✅	-11.56%
pedersen_commitment	-47 ✅	-16.04%
brillig_pedersen	-190 ✅	-19.55%
pedersen_check	-190 ✅	-19.55%
regression_bignum	-128 ✅	-20.35%
pedersen_hash	-143 ✅	-21.38%

---

Full diff report 👇

Program	Brillig opcodes (+/-)	%
bench_2_to_17	589,838 (-3)	-0.00%
fold_2_to_17	1,093,919 (-6)	-0.00%
regression_4449	200,854 (-3)	-0.00%
regression_5252	914,986 (-40)	-0.00%
poseidonsponge_x5_254	183,645 (-108)	-0.06%
slice_dynamic_index	4,664 (-3)	-0.06%
poseidon_bn254_hash	162,443 (-151)	-0.09%
poseidon_bn254_hash_width_3	162,443 (-151)	-0.09%
strings	1,767 (-3)	-0.17%
array_to_slice	1,667 (-3)	-0.18%
hashmap	54,035 (-105)	-0.19%
regression	2,810 (-6)	-0.21%
slice_loop	939 (-3)	-0.32%
regression_6674_2	819 (-3)	-0.36%
regression_6674_1	816 (-3)	-0.37%
sha256_var_size_regression	16,311 (-66)	-0.40%
poseidon2	695 (-3)	-0.43%
debug_logs	5,136 (-24)	-0.47%
u128	24,831 (-131)	-0.52%
brillig_cow_assign	533 (-3)	-0.56%
uhashmap	144,658 (-888)	-0.61%
fold_complex_outputs	762 (-6)	-0.78%
slices	3,335 (-30)	-0.89%
nested_array_dynamic	3,417 (-47)	-1.36%
regression_4202	211 (-3)	-1.40%
reference_counts	397 (-6)	-1.49%
sha256_regression	116,673 (-1,890)	-1.59%
sha256_brillig_performance_regression	22,814 (-380)	-1.64%
conditional_regression_661	117 (-3)	-2.50%
sha2_byte	45,877 (-1,432)	-3.03%
regression_6674_3	1,561 (-54)	-3.34%
ecdsa_secp256k1	6,540 (-249)	-3.67%
fold_numeric_generic_poseidon	4,941 (-202)	-3.93%
no_predicates_numeric_generic_poseidon	4,941 (-202)	-3.93%
fold_call_witness_condition	67 (-3)	-4.29%
simple_shield	2,716 (-155)	-5.40%
array_dynamic_nested_blackbox_input	4,301 (-249)	-5.47%
conditional_regression_short_circuit	7,030 (-498)	-6.62%
keccak256	32,474 (-2,303)	-6.62%
6	6,952 (-498)	-6.68%
ram_blowup_regression	721,038 (-57,612)	-7.40%
sha256	13,865 (-1,127)	-7.52%
brillig_cow_regression	479,934 (-39,152)	-7.54%
sha256_var_padding_regression	205,416 (-16,794)	-7.56%
7_function	2,333 (-204)	-8.04%
aes128_encrypt	4,326 (-393)	-8.33%
conditional_1	5,225 (-492)	-8.61%
sha256_var_witness_const_regression	6,571 (-629)	-8.74%
wildcard_type	471 (-47)	-9.07%
to_be_bytes	2,216 (-236)	-9.62%
regression_struct_array_conditional	1,515 (-164)	-9.77%
databus_two_calldata	399 (-47)	-10.54%
brillig_oracle	2,433 (-318)	-11.56%
pedersen_commitment	246 (-47)	-16.04%
brillig_pedersen	782 (-190)	-19.55%
pedersen_check	782 (-190)	-19.55%
regression_bignum	501 (-128)	-20.35%
pedersen_hash	526 (-143)	-21.38%

[jfecher]

I'm unsure what the issue with noir_bigcurve was. I tested it and found that not only does the test pass on the main branch, it also passes on what I believe to be the original commit for issue #6763: commit 2cd193 or e1f1c9

[vezenovm]

I'm unsure what the issue with noir_bigcurve was. I tested it and found that not only does the test pass on the main branch, it also passes on what I believe to be the original commit for issue #6763: commit 2cd193 or e1f1c9

Hmm this is strange. Perhaps the RC tracker fixes were not in yet when that issue was filed?

[vezenovm]

Approving as all tests look to be passing and we are seeing some pretty good improvements.