Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Reserve enum and match keywords #6961

Merged
merged 4 commits into from
Jan 8, 2025
Merged

chore!: Reserve enum and match keywords #6961

merged 4 commits into from
Jan 8, 2025

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jan 6, 2025

Description

Problem*

Summary*

Reserves "enum" and "match" as keywords to avoid breaking code post-1.0. These keywords are eventually planned to be used in implementing enumerations in Noir.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher requested a review from a team January 6, 2025 20:58
@jfecher jfecher enabled auto-merge January 6, 2025 20:58
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Compilation Report

Program Compilation Time %
sha256_regression 1.056s 4%
regression_4709 0.793s 1%
ram_blowup_regression 15.140s 2%
rollup-root 3.680s 1%
rollup-block-merge 3.540s -13%
rollup-base-public 29.900s 1%
rollup-base-private 11.800s 8%
private-kernel-tail 1.052s 9%
private-kernel-reset 8.780s 1%
private-kernel-inner 2.018s -1%

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Execution Report

Program Execution Time %
sha256_regression 0.056s 3%
regression_4709 0.001s 0%
ram_blowup_regression 0.582s 0%
rollup-root 0.106s 0%
rollup-block-merge 0.106s 0%
rollup-base-public 1.320s -1%
rollup-base-private 0.523s 1%
private-kernel-tail 0.022s 0%
private-kernel-reset 0.384s 0%
private-kernel-inner 0.097s 1%

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Execution Memory Report

Program Peak Memory
keccak256 74.65M
workspace 123.56M
regression_4709 315.98M
ram_blowup_regression 512.41M
rollup-base-public 492.17M
rollup-base-private 332.25M
private-kernel-tail 181.08M
private-kernel-reset 254.94M
private-kernel-inner 212.77M

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Compilation Memory Report

Program Peak Memory
keccak256 78.55M
workspace 123.42M
regression_4709 422.96M
ram_blowup_regression 1.58G
rollup-base-public 2.55G
rollup-base-private 1.24G
private-kernel-tail 200.40M
private-kernel-reset 728.14M
private-kernel-inner 290.48M

@jfecher jfecher added this pull request to the merge queue Jan 8, 2025
Merged via the queue into master with commit e08f4fa Jan 8, 2025
87 checks passed
@jfecher jfecher deleted the jf/reserve-enum branch January 8, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants