Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
No issue just something I noticed while working on globals. I wanted to be able to re-use the SSA printer for globals but most printer functions accept a
Function
type as input. However, they all only usefunction.dfg
in the function and none of the other fields fromFunction
. I want to be able to re-use these printer functions if I have aDataFlowGraph
but not aFunction
.Summary*
I updated most methods under
ir/printer.rs
to accept aDataFlowGraph
and use it directly.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.