Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use DFG in SSA printer #6986

Merged
merged 1 commit into from
Jan 8, 2025
Merged

chore: Use DFG in SSA printer #6986

merged 1 commit into from
Jan 8, 2025

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Jan 8, 2025

Description

Problem*

No issue just something I noticed while working on globals. I wanted to be able to re-use the SSA printer for globals but most printer functions accept a Function type as input. However, they all only use function.dfg in the function and none of the other fields from Function. I want to be able to re-use these printer functions if I have a DataFlowGraph but not a Function.

Summary*

I updated most methods under ir/printer.rs to accept a DataFlowGraph and use it directly.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm vezenovm requested a review from a team January 8, 2025 15:22
@jfecher jfecher enabled auto-merge January 8, 2025 15:26
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Execution Report

Program Execution Time %
sha256_regression 0.054s 0%
regression_4709 0.001s 0%
ram_blowup_regression 0.577s -1%
rollup-root 0.106s 0%
rollup-block-merge 0.106s 0%
rollup-base-public 1.330s 0%
rollup-base-private 0.522s 1%
private-kernel-tail 0.022s 0%
private-kernel-reset 0.385s 0%
private-kernel-inner 0.097s 1%

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Compilation Report

Program Compilation Time %
sha256_regression 1.040s 2%
regression_4709 0.774s -1%
ram_blowup_regression 15.160s 2%
rollup-root 3.550s -2%
rollup-block-merge 3.630s -11%
rollup-base-public 29.600s 0%
rollup-base-private 11.300s 3%
private-kernel-tail 0.979s 2%
private-kernel-reset 8.720s 1%
private-kernel-inner 2.030s 0%

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Compilation Memory Report

Program Peak Memory
keccak256 78.55M
workspace 123.50M
regression_4709 422.96M
ram_blowup_regression 1.58G
rollup-base-public 2.55G
rollup-base-private 1.24G
private-kernel-tail 200.40M
private-kernel-reset 728.14M
private-kernel-inner 290.46M

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Execution Memory Report

Program Peak Memory
keccak256 74.65M
workspace 123.68M
regression_4709 315.98M
ram_blowup_regression 512.41M
rollup-base-public 492.17M
rollup-base-private 332.25M
private-kernel-tail 181.08M
private-kernel-reset 254.94M
private-kernel-inner 212.77M

@jfecher jfecher added this pull request to the merge queue Jan 8, 2025
Merged via the queue into master with commit bb8dd5c Jan 8, 2025
87 checks passed
@jfecher jfecher deleted the mv/use-dfg-in-ssa-printer branch January 8, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants