feat: expand ${workspaceFolder} in nargoPath setting
#91
+20
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
requested review from
TomAFrench and
a team
and removed request for
TomAFrench
TomAFrench
approved these changes
Jan 8, 2025
|
Yes! I tried it locally by placing a |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Asked by Palla, it seems it'll be useful to use in Aztec-Packages.
Summary
VSCode doesn't automatically expand variables in settings so some plugins do it. There's no convention about which names to use but at least the cmake plugin uses
workspaceFolderfor the workspace folder, and that's probably the most useful one to have to configurenargorelative to it... so that's just what this PR does.Additional Context
After merging this PR we'd probably need a new release so it can be used.
PR Checklist
cargo fmton default settings.