lib/streamaggr: explicitly call resetSeries after flushSeries

This makes the code less fragile
nokia · Mar 4, 2024 · 8649451 · 8649451
1 parent ac3cf3f
commit 8649451
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/streamaggr/streamaggr.go b/lib/streamaggr/streamaggr.go
@@ -674,6 +674,7 @@ func (a *aggregator) flush(pushFunc PushFunc) {
 			ctx := getFlushCtx(a, pushFunc)
 			as.flushState(ctx)
 			ctx.flushSeries()
+			ctx.resetSeries()
 			putFlushCtx(ctx)
 		}(as)
 	}
@@ -925,8 +926,6 @@ func (ctx *flushCtx) flushSeries() {
 	}
 	auxLabels.Labels = dstLabels
 	promutils.PutLabels(auxLabels)
-
-	ctx.resetSeries()
 }
 
 func (ctx *flushCtx) appendSeries(key, suffix string, timestamp int64, value float64) {
@@ -948,6 +947,7 @@ func (ctx *flushCtx) appendSeries(key, suffix string, timestamp int64, value flo
 	// Limit the maximum length of ctx.tss in order to limit memory usage.
 	if len(ctx.tss) >= 10_000 {
 		ctx.flushSeries()
+		ctx.resetSeries()
 	}
 }