fix rlp decoding bug (#5)

nomo-app · Nov 17, 2023 · 13e7266 · 13e7266
1 parent 04060a2
commit 13e7266
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/lib/src/crypto/evm/function_signature.dart b/lib/src/crypto/evm/function_signature.dart
@@ -113,7 +113,7 @@ class FunctionSignature {
 
     if (contractFunction == null) {
       return FunctionSignature(
-        "unknown",
+        "function not found",
         null,
         decodeDataValues(data, {}),
       );

diff --git a/lib/src/crypto/evm/rlp.dart b/lib/src/crypto/evm/rlp.dart
@@ -134,7 +134,8 @@ Transaction getTransactionFromMessageHash(String messageHex) {
   BigInt gasPrice = parseAsHexBigInt(en.result[1]);
   BigInt gasLimit = parseAsHexBigInt(en.result[2]);
   String evmAddress = en.result[3];
-  BigInt value = parseAsHexBigInt(en.result[4]);
+
+  BigInt value = parseAsHexBigInt(en.result[4] == "" ? "0x0" : en.result[4]);
   final Uint8List data = Uint8List.fromList(hex.decode(en.result[5]));
 
   return Transaction(

diff --git a/lib/walletkit_dart.dart b/lib/walletkit_dart.dart
@@ -52,3 +52,5 @@ export 'src/domain/entities/hd_wallet_type.dart';
 export 'src/domain/entities/address_type.dart';
 
 export 'src/crypto/evm/rlp.dart';
+
+export 'src/crypto/evm/function_signature.dart';
diff --git a/test/ci/parsing/reverse-hash-computation_test.dart b/test/ci/parsing/reverse-hash-computation_test.dart
@@ -1,7 +1,6 @@
 import 'dart:typed_data';
 import 'package:convert/convert.dart';
 import 'package:test/test.dart';
-import 'package:walletkit_dart/src/crypto/evm/function_signature.dart';
 import 'package:walletkit_dart/walletkit_dart.dart';
 
 void main() {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -52,3 +52,5 @@ export 'src/domain/entities/hd_wallet_type.dart';
		export 'src/domain/entities/address_type.dart';

		export 'src/crypto/evm/rlp.dart';

		export 'src/crypto/evm/function_signature.dart';