Migrate Tests

nomo-app · Nov 11, 2024 · 797f0c1 · 797f0c1
1 parent ce5fa8c
commit 797f0c1
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 6 deletions.
diff --git a/lib/src/crypto/evm/entities/contract/contract_function.dart b/lib/src/crypto/evm/entities/contract/contract_function.dart
@@ -78,6 +78,11 @@ sealed class ContractFunction implements ExternalContractFunctionMixin {
   }) {
     final opening = textSignature.indexOf("(");
     final closing = textSignature.lastIndexOf(")");
+
+    if (opening == -1 || closing == -1) {
+      throw Exception("Invalid text signature: $textSignature");
+    }
+
     final name = textSignature.substring(0, opening);
     final params_s = extractParams(
       textSignature.substring(opening + 1, closing),
@@ -147,7 +152,7 @@ sealed class ContractFunction implements ExternalContractFunctionMixin {
     if (functionMap != null) {
       final localResult = decodeRaw(data: data, functionMap: functionMap);
 
-      if (localResult is! UnknownContractFunction ||
+      if (localResult is! UnknownContractFunction &&
           localResult is! NotDecodableContractFunction) {
         return localResult;
       }
@@ -181,8 +186,13 @@ sealed class ContractFunction implements ExternalContractFunctionMixin {
 
     if (text_signarure == null) return UnknownContractFunction(data: data);
 
-    final function =
-        ContractFunction.fromTextSignature(textSignature: text_signarure);
+    final ExternalContractFunction function;
+    try {
+      function =
+          ContractFunction.fromTextSignature(textSignature: text_signarure);
+    } catch (e) {
+      return UnknownContractFunction(data: data);
+    }
 
     return ContractFunction.decode(
       data: data,

diff --git a/test/ci/parsing/fetch_function_signature_test.dart b/test/ci/parsing/fetch_function_signature_test.dart
@@ -151,7 +151,7 @@ void main() {
     contractFunction = await ContractFunction.decodeRawWithFetch(
       data: dataString.hexToBytesWithPrefix,
       functionMap: {
-        "0x3f8fc233": "cancelTrades((bytes32,uint256,uint256)[])",
+        "3f8fc233": "cancelTrades((bytes32,uint256,uint256)[])",
       },
     );
 
@@ -424,7 +424,7 @@ void main() {
     final contractFunction = await ContractFunction.decodeRawWithFetch(
       data: dataString.hexToBytesWithPrefix,
       functionMap: {
-        "0x2289b18c": "g(uint256[][],string[])",
+        "2289b18c": "g(uint256[][],string[])",
       },
     );
 

diff --git a/test/ci/parsing/reverse-hash-computation_test.dart b/test/ci/parsing/reverse-hash-computation_test.dart
@@ -4,7 +4,12 @@ import 'package:test/test.dart';
 import 'package:walletkit_dart/walletkit_dart.dart';
 
 void main() {
-  const functionMap = {"asd": "asd"};
+  const functionMap = {
+    "40c10f19": "mint(address,uint256)",
+    "6ba4c138": "claim(uint256[])",
+    "d63a47d6":
+        "mint(address _to,uint256 _amount,bytes[] _amounts,bool _collect,address[] _addresses,int256 _intParam)",
+  };
   test('extract functionSignature mint from the transaction', () {
     const String unsignedTxFromNomo = // from nomo.signEvmTransaction
         "0xf86982074b8504a817c80083029810946d3be2fca848393ee83b2a1d65b312889cacf5e680b84440c10f1900000000000000000000000005870f1507d820212e921e1f39f14660336231d10000000000000000000000000000000000000000000000000000000000f34344";