Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bucket notifications - add action to encrypt connection file #8684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alphaprinz
Copy link
Contributor

Explain the changes

Before this change the connection file was completely plain text, including the http basic authentication header.
This change adds API to manipulate connection files, adding the logic to encrypt this field when a connection file is created.

The new CONNECTION type is introduced, along with standard CRUD actions.
The 'STATUS' action also includes a 'decrypt' flag to decrypt connection file into plain text.

Issues: Fixed #xxx / Gap #xxx

  1. password is getting exposed in connections_kv.json file  #8643

Testing Instructions:

  1. Using manage_nsfs cli, create a connection with the "auth" option under request_options_object.
  2. The auth field is encrypted.
  3. Notifications work as intended using the connection. IE, auth header is sent in plain text.
  • Doc added/updated
  • Tests added

Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant