Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring installFromFS from notation CLI to notation-go #852

Closed
Two-Hearts opened this issue Dec 20, 2023 · 1 comment
Closed

Refactoring installFromFS from notation CLI to notation-go #852

Two-Hearts opened this issue Dec 20, 2023 · 1 comment

Comments

@Two-Hearts
Copy link
Contributor

Originally posted by @shizhMSFT in #827 (comment)

Created issue to track.
@Two-Hearts Two-Hearts mentioned this issue Dec 20, 2023
Merged
@Two-Hearts
Copy link
Contributor Author

Two-Hearts commented Dec 25, 2023 •
edited
Loading

Closing this issue as we have discussed this again. The reason to close is that:
Even if we move the fs.FS logic, such as zip related functions, to notation-go, we still have to have a tmp dir to unzip before the installation. This is because get-plugin-metadata requires os path to execute. Golang's io/fs does not provide os path information during WalkDir.
/cc: @shizhMSFT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Notary Project Planning Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Two-Hearts