Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notation inspect command timestamp signature support #997

Closed
JeyJeyGao opened this issue Jul 26, 2024 · 2 comments · Fixed by #998
Closed

Notation inspect command timestamp signature support #997

JeyJeyGao opened this issue Jul 26, 2024 · 2 comments · Fixed by #998
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JeyJeyGao
Copy link
Contributor

Is your feature request related to a problem?

image
The timestamp signature field is base64 encoded; however, it is not readable.

What solution do you propose?

For the notation inspect command, we need to provide readable content for humans. Therefore, for the timestamp signature, we may need to show the actual timestamp, issuer, and the content of the timestamping certificate chain.

What alternatives have you considered?

No

Any additional context?

No

@JeyJeyGao JeyJeyGao added enhancement New feature or request triage Need to triage labels Jul 26, 2024
@Two-Hearts Two-Hearts self-assigned this Jul 26, 2024
@Two-Hearts Two-Hearts added this to the 1.2.0 milestone Jul 26, 2024
@Two-Hearts
Copy link
Contributor

A valid issue. Should fix before next release.

@Two-Hearts
Copy link
Contributor

Two-Hearts commented Jul 26, 2024

the content of the timestamping certificate chain this part is not showable, because we can only get the tsa cert chain during timestamp verification where the user must provide the TSA root cert.

(We could show all the certificates within the timestamp signature with random order though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants