Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: release v1.1.2 #1060

Merged
merged 1 commit into from
Oct 15, 2024
Merged

bump: release v1.1.2 #1060

merged 1 commit into from
Oct 15, 2024

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Oct 9, 2024 •
edited by priteshbandi
Loading

Release

This would mean tagging d055873 as v1.1.2 to release.

This release removed the blob signing docs and fixed the signingAgent value to be notation-go/1.1.2

Vote

We need at least 4 approvals from 6 maintainers to release v1.1.2.

What's Changed

Full Changelog: v1.1.1...d055873

@JeyJeyGao
bump: release v1.1.2
d055873 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.30%. Comparing base (65ee9d8) to head (d055873).
Report is 2 commits behind head on release-1.1.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-1.1    #1060   +/-   ##
============================================
  Coverage        71.30%   71.30%           
============================================
  Files               45       45           
  Lines             2171     2171           
============================================
  Hits              1548     1548           
  Misses             429      429           
  Partials           194      194

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao
Copy link
Contributor Author

LGTM

shizhMSFT
shizhMSFT approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two-Hearts
Two-Hearts approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit d9087ba into notaryproject:release-1.1 Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeyJeyGao @priteshbandi @shizhMSFT @Two-Hearts