Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Code scanning issues #799

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Oct 10, 2023

Fix:

  • Token-Permissions issue for dev-release.yml: delete the file
  • Token-Permissions issue for license-checker.yml: update the global permission to be read

Resolves part of #408
Signed-off-by: Junjie Gao junjiegao@microsoft.com

@JeyJeyGao JeyJeyGao changed the title fix: scorecard fix: Code scanning issues Oct 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Merging #799 (925f9ab) into main (93e6853) will increase coverage by 63.98%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff            @@
##           main     #799       +/-   ##
=========================================
+ Coverage      0   63.98%   +63.98%     
=========================================
  Files         0       40       +40     
  Lines         0     2252     +2252     
=========================================
+ Hits          0     1441     +1441     
- Misses        0      689      +689     
- Partials      0      122      +122     

see 40 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Two-Hearts
Two-Hearts previously approved these changes Oct 10, 2023
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes Oct 10, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Glad to see we deprecate the dev release which is not used for a long time.

priteshbandi
priteshbandi previously approved these changes Oct 10, 2023
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 6265bf8 into notaryproject:main Oct 12, 2023
5 checks passed
Two-Hearts pushed a commit to Two-Hearts/notation that referenced this pull request Nov 3, 2023
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
shizhMSFT pushed a commit that referenced this pull request Nov 3, 2023
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
shizhMSFT pushed a commit that referenced this pull request Nov 3, 2023
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@shizhMSFT shizhMSFT mentioned this pull request Nov 6, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants