Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nonce is set directly in params, kills the ability to retry without rebuilding params #55

Open
pjbrinck opened this issue Apr 23, 2018 · 0 comments

Comments

@pjbrinck
Copy link

pjbrinck commented Apr 23, 2018

I'm using a pattern of

function callKraken(method, params, next) {
	async.retry(3, next => {
    		kraken.api(method, params, next);
	}, next); 
}

If I rely on Kraken-Api to set the nonce, then all my retries will fail with "API: Invalid nonce".

Work around: I'll set the nonce myself.
Fix suggestion: Kraken-Api does not alter params other than a possible copy of params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant