Ensure that LineItem.TipPaymentGateway is always deserialized so that…

… the TipPaymentGatewaySpecified property gets set.
nozzlegear · Nov 27, 2022 · 5d4e03e · 5d4e03e
1 parent 7528eb5
commit 5d4e03e
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/ShopifySharp.Tests/Order_Tests.cs b/ShopifySharp.Tests/Order_Tests.cs
@@ -205,6 +205,24 @@ public async Task Can_Be_Partially_Updated()
             // In previous versions of ShopifySharp, the updated JSON would have sent 'email=null', clearing out the email address.
             Assert.Equal(created.Email, updated.Email);
         }
+
+        [Fact]
+        public void TipPaymentGatewaySpecified_GetDeserialized()
+        {
+            string orderJson = @"{
+  ""id"": 123,
+  ""line_items"": [
+    {
+      ""id"": 123,
+      ""tip_payment_gateway"": null
+    }
+  ]
+}
+";
+            var order = Infrastructure.Serializer.Deserialize<Order>(orderJson);
+            Assert.Null(order.LineItems.First().TipPaymentGateway);
+            Assert.True(order.LineItems.First().TipPaymentGatewaySpecified);
+        }
     }
 
     public class Order_Tests_Fixture : IAsyncLifetime

diff --git a/ShopifySharp/Entities/LineItem.cs b/ShopifySharp/Entities/LineItem.cs
@@ -118,7 +118,7 @@ public class LineItem : ShopifyObject
         /// <summary>
         /// The payment gateway used to tender the tip, such as shopify_payments. Present only on tips.
         /// </summary>
-        [JsonProperty("tip_payment_gateway")]
+        [JsonProperty("tip_payment_gateway", NullValueHandling = NullValueHandling.Include)]
         public string TipPaymentGateway { get; set; }
 
         /// <summary>