Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RefundLineItem SubTotalTaxSet - copypaste issue? #1071

Open
nyan-cat opened this issue May 17, 2024 · 1 comment
Open

RefundLineItem SubTotalTaxSet - copypaste issue? #1071

nyan-cat opened this issue May 17, 2024 · 1 comment

Comments

@nyan-cat
Copy link

RefundLineItem has this decimal property:

[JsonProperty("total_tax")]
public decimal? TotalTax { get; set; }

And PriceSet version of it:

[JsonProperty("total_tax_set")]
public PriceSet TotalTaxSet { get; set; }

All good so far. Also it has this decimal property:

[JsonProperty("subtotal")]
public decimal? SubTotal { get; set; }

And this PriceSet version:

[JsonProperty("subtotal_set")]
public PriceSet SubTotalTaxSet { get; set; }

JSON name is subtotal_set, but C# name is SubTotalTaxSet. Is that a typo? Shouldn't it be just SubTotalSet, which is not related to taxes?

@nozzlegear
Copy link
Owner

Hey, good catch! It does look like a copy/paste issue. I'll get this fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants